Make upgrade install new host first, then uninstall old #60307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should preserve the ordering of PATH, since the old MSI will never remove its entry.
ericstj
requested review from
jkoritzinsky,
joeloff,
NikolaMilosavljevic,
vitek-karas,
marcpopMSFT and
hoyosjs
ghost
added this to In Progress
in 
joeloff
approved these changes
Oct 12, 2021
hoyosjs
approved these changes
Oct 12, 2021
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1335045586 |
|
/backport to release/5.0 |
|
Started backporting to release/5.0: https://github.com/dotnet/runtime/actions/runs/1335430321 |
|
@ericstj backporting to release/5.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Make upgrade install new host first, then uninstall old
Using index info to reconstruct a base tree...
A src/installer/pkg/sfx/installers/dotnet-host.proj
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): src/installer/pkg/sfx/installers/dotnet-host.proj deleted in HEAD and modified in Make upgrade install new host first, then uninstall old. Version Make upgrade install new host first, then uninstall old of src/installer/pkg/sfx/installers/dotnet-host.proj left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Make upgrade install new host first, then uninstall old
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
This was referenced Oct 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should preserve the ordering of PATH, since the old MSI will never
remove its entry.
Requires dotnet/arcade#8025