[API Implementation]: SafeFileHandle overloads for SetCreationTime, SetLastAccessTime, SetLastWriteTime

[deeprobin]

Proposal implementation of #20234 (closes #20234)

Proposal

namespace System.IO
{
    public static partial class File
    {
        public static DateTime GetCreationTime(SafeFileHandle fileHandle);
        public static DateTime GetCreationTimeUtc(SafeFileHandle fileHandle);
        public static DateTime GetLastAccessTime(SafeFileHandle fileHandle);
        public static DateTime GetLastAccessTimeUtc(SafeFileHandle fileHandle);
        public static DateTime GetLastWriteTime(SafeFileHandle fileHandle);
        public static DateTime GetLastWriteTimeUtc(SafeFileHandle fileHandle);

        public static void SetCreationTime(SafeFileHandle fileHandle, DateTime creationTime);
        public static void SetCreationTimeUtc(SafeFileHandle fileHandle, DateTime creatinTimeUtc);
        public static void SetLastAccessTime(SafeFileHandle fileHandle, DateTime lastAccessTime);
        public static void SetLastAccessTimeUtc(SafeFileHandle fileHandle, DateTime lastAccessTimeUtc);
        public static void SetLastWriteTime(SafeFileHandle fileHandle, DateTime lastWriteTime);
        public static void SetLastWriteTimeUtc(SafeFileHandle fileHandle, DateTime lastWriteTimeUtc);

        public static FileAttributes GetAttributes(SafeFileHandle fileHandle);
        public static void SetAttributes(SafeFileHandle fileHandle, FileAttributes fileAttributes);
    }
}

Current state of implementation

• Proposal logic / implementation
  • Windows
  • Unix
• Ref Assembly
• Tests

/cc @Liryna

[ghost]

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Proposal implementation of #20234

⚠️ This is a draft

/cc @Liryna

Author:	deeprobin
Assignees:	-
Labels:	area-System.IO, community-contribution
Milestone:	-

[deeprobin]

@danmoseley Do the files added under Common/src/Interop/Windows/Kernel32/ (see CI failures) have to be registered somewhere so that they can be resolved?

[danmoseley]

@deeprobin if you look at the build log you should see the project file on the end of the error:

2021-10-22T19:42:24.8792107Z D:\a\_work\2\s\src\libraries\Common\src\Interop\Windows\Kernel32\Interop.WIN32_FILE_ATTRIBUTE_DATA.cs(27,44): error CS0246: The type or namespace name 'BY_HANDLE_FILE_INFORMATION' could not be found (are you missing a using directive or an assembly reference?) [D:\a\_work\2\s\src\libraries\System.IO.FileSystem.AccessControl\src\System.IO.FileSystem.AccessControl.csproj]

You've introduced use of WIN32_FILE_ATTRIBUTE_DATA into a file in this project: the project file needs updating to include its source file.

[danmoseley]

@deeprobin are you able to build the libraries locally successfully? An incremental build under src\libraries should be less than a minute, and ought to have thrown up these errors locally, which would be quicker for you than waiting an hour or whatever for the PR validation system.

[danmoseley]

Generally folks don't push changes one at a time, because it restarts PR validation, which is extensive -- 50+ configurations -- and that uses machine capacity. What I suggest is that you wait to push until you are satisfied with your changes and have done basic build and tests locally, then push everything (squashed or not as you prefer). Another option is that I mark this PR as draft, so that pushes don't kick off more validation (I think). What are your thoughts

[deeprobin]

Generally folks don't push changes one at a time, because it restarts PR validation, which is extensive -- 50+ configurations -- and that uses machine capacity. What I suggest is that you wait to push until you are satisfied with your changes and have done basic build and tests locally, then push everything (squashed or not as you prefer). Another option is that I mark this PR as draft, so that pushes don't kick off more validation (I think). What are your thoughts

Unfortunately, VS support doesn't currently work for me with .NET 7, so I've always validated that via CI.

[danmoseley]

VS support doesn't currently work for me with .NET 7

You can build and run tests outside of VS. this is what I do. There is all the info you need in the workflow docs in this repo.

[danmoseley]

@deeprobin it looks like there's unix specific build errors. You don't need to be on a Unix box to reproduce those. Something like this at the root of the repo:
build clr.corelib -rc release -lc debug -os linux
or to build all the libraries
build clr.corelib+libs -rc release -lc debug -os linux

There should be a way to do it with dotnet build, but I have to check how.

[deeprobin]

@danmoseley Thank you. I'll fixed it (the unix-build is now passing locally)

[danmoseley]

It looks like you need to rebase on main as I made a concurrent change. It should be easy.

[danmoseley]

Can you please open a new issue for your failure:

Process terminated. Assertion failed.
ClientCertificates. Expected enumerable cloned value.
   at System.Net.Security.SslClientAuthenticationOptionsExtensions.ShallowClone(SslClientAuthenticationOptions options) in /_/src/libraries/Common/src/System/Net/Security/SslClientAuthenticationOptionsExtensions.cs:line 41
   at System.Net.Http.HttpConnectionSettings.CloneAndNormalize() in /_/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionSettings.cs:line 85
   at System.Net.Http.SocketsHttpHandler.SetupHandlerChain() in /_/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/SocketsHttpHandler.cs:line 486
   at System.Net.Http.SocketsHttpHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken) in /_/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/SocketsHttpHandler.cs:line 576

[danmoseley]

Cc @wfurt

[deeprobin]

@Jozkee @danmoseley
I think this PR is ready-for-merge or do you find any possible improvements?

[deeprobin]

@Jozkee Can you give another review (or approve)?

[Jozkee]

@deeprobin if you are not planning on addressing the documentation feedback, could you please file an issue for it?

[deeprobin]

@deeprobin if you are not planning on addressing the documentation feedback, could you please file an issue for it?

I'll address it. Give me one hour ;)

[deeprobin]

@Jozkee Doc changes applied

[Jozkee]

CI error is #66625

[Jozkee]

Thanks, @deeprobin.