Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PKCS#8 and SPKI PEM Exports #61439

Merged
merged 2 commits into from
Nov 11, 2021
Merged

PKCS#8 and SPKI PEM Exports #61439

merged 2 commits into from
Nov 11, 2021

Conversation

vcsjones
Copy link
Member

This implements PEM exports for PKCS#8 and SubjectPublicKeyInfo keys on AsymemtricAlgorithm.

Contributes to #51630. The only remaining work after this PR will be for ECPrivateKey for ECDsa and ECDiffieHellman and PKCS#1 RSAPrivateKey on RSA.

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Nov 10, 2021
@ghost
Copy link

ghost commented Nov 10, 2021

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details

This implements PEM exports for PKCS#8 and SubjectPublicKeyInfo keys on AsymemtricAlgorithm.

Contributes to #51630. The only remaining work after this PR will be for ECPrivateKey for ECDsa and ECDiffieHellman and PKCS#1 RSAPrivateKey on RSA.

Author: vcsjones
Assignees: -
Labels:

area-System.Security, new-api-needs-documentation
Milestone: -

@bartonjs
Copy link
Member

Danke. Nice work :)

@bartonjs bartonjs merged commit 2099752 into dotnet:main Nov 11, 2021
@vcsjones vcsjones deleted the asymmetric-pem-export branch November 11, 2021 21:51
@vcsjones
Copy link
Member Author

Apparently the secret to success is to grep for \n{3,} before opening the pull request.

@kunalspathak kunalspathak mentioned this pull request Dec 10, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 20, 2021
@bartonjs bartonjs added the needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration label Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bartonjs bartonjs bartonjs approved these changes

Assignees
No one assigned
Labels
area-System.Security community-contribution Indicates that the PR has been added by a community member needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vcsjones @bartonjs