Implement PEM exports for RSA PKCS#1 and ECPrivateKey #61487
Conversation
ghost
added
the
community-contribution
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
@bartonjs this is all in S.S.C.Algorithms. I'm not sure if you are in the middle of moving that down in to the new S.S.Cryptography assembly. If you have that in-flight, it's probably easier for me to rebase on that work than for this to get merged and you rebase on top of that. If that is the case, please feel free to hold this PR until that's complete and I'll respond to the things moving around. |
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue DetailsCloses out #51630.
|
Yep, have it all merged in locally, except Browser.
OK, I'll go ahead and mark this as no-merge. It should be actionable late-this or early-next week. |
bartonjs
added
the
NO-MERGE
|
The code LGTM, just needs to be rebased on a future commit :) |
The diminished DP/DQ values are exported different on Windows 7. Use a key that will behave the same on all platforms.
The way RSA exports keys private keys is not consistent between platforms and brittle. Change the tests to use well-known data for PEM exports so the tests are stable.
|
Since #61516 changed some of the APIs here, I am going to close this PR and re-open it after that PR is complete. |
Closes #51630.