Change all "unmanaged" (no GC fields) sequential types to have sequential layout. #61759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoritzinsky
force-pushed
the
managedseqential_unmanaged
branch
from
d5e15d0
to
3c4ccbc
Compare
This was referenced Nov 19, 2021
jkoritzinsky
force-pushed
the
managedseqential_unmanaged
branch
from
0735747
to
b85447d
Compare
…al structs in managed-sequential layout
jkoritzinsky
requested review from
jkotas,
trylek,
elinor-fung and
AaronRobinsonMSFT
jkotas
reviewed
Nov 29, 2021
src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/ReadyToRunMetadataFieldLayoutAlgorithm.cs
Show resolved
Hide resolved
jkotas
reviewed
Nov 30, 2021
src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/ReadyToRunMetadataFieldLayoutAlgorithm.cs
Outdated
Show resolved
Hide resolved
…nMetadataFieldLayoutAlgorithm.cs Co-authored-by: Jan Kotas <jkotas@microsoft.com>
…all other scenarios (align-up to strictest alignment of members)
jkotas
reviewed
Nov 30, 2021
src/coreclr/tools/Common/TypeSystem/Common/MetadataFieldLayoutAlgorithm.cs
Outdated
Show resolved
Hide resolved
…Algorithm.cs Co-authored-by: Jan Kotas <jkotas@microsoft.com>
This was referenced Nov 30, 2021
Closed
Closed
jkotas
reviewed
Nov 30, 2021
src/coreclr/tools/Common/TypeSystem/Common/MetadataFieldLayoutAlgorithm.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Dec 13, 2021
|
/azp run runtime-coreclr crossgen2 outerloop,runtime-coreclr crossgen2-composite |
jkotas
reviewed
Dec 13, 2021
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
It looks good to me (once it builds on all platforms). Are you happy with the test coverage we have for this, or do you plan to add more tests? It would be useful to also get a review from @trylek or @davidwrighton . |
trylek
approved these changes
Dec 13, 2021
… and the type has GC pointers.
|
/azp run runtime-coreclr crossgen2 outerloop,runtime-coreclr crossgen2-composite |
|
Azure Pipelines successfully started running 2 pipeline(s). |
…layout. Update a comment so we aren't confused when looking back here in the future.
…runtime into managedseqential_unmanaged
|
/azp run runtime-coreclr crossgen2 outerloop,runtime-coreclr crossgen2-composite |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
It looks like the macOS ARM64 test failures are #62747 due to the following multidimensional array: |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prereq for #60639
This enables us to use the managed layout as the native layout for all LayoutKind.Sequential "C# unmanaged" structs, which is required for reconciling the "unmanaged" and "blittable" concepts.
Fixes #44579
Fixes #12977