You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebProxy has new(Uri Address), new(string Address), new(string Host, int Port) constructors that all behave differently.
The new(string) overload will check if the address is an absolute Uri and add a "http://" prefix otherwise.
The new(string, int) overload will blindly concat the host and port $"http://{Host}:{Port}".
If you happentocreate a WebProxy object like new WebProxy("socks5://127.0.0.1", 9050), what you actually end up with is a proxy to "http://socks5://127.0.0.1:9050" - an http proxy with the host socks5 and a default port.
We should either check if the host is already an absolute Uri like we do for other overloads (this PR), or we should throw. socks5://127.0.0.1 is not a valid host, it just happens to be interpreted as:
Host: socks5
Port: : (empty port is allowed and means "default for the scheme")
Path: //127.0.0.1
cc: @ManickaP who noticed our blog posts announcing socks support have broken code snippets.
Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.
Issue Details
WebProxy has new(Uri Address), new(string Address), new(string Host, int Port) constructors that all behave differently.
The new(string) overload will check if the address is an absolute Uri and add a "http://" prefix otherwise.
The new(string, int) overload will blindly concat the host and port $"http://{Host}:{Port}".
If you happentocreate a WebProxy object like new WebProxy("socks5://127.0.0.1", 9050), what you actually end up with is a proxy to "http://socks5://127.0.0.1:9050" - an http proxy with the host socks5 and a default port.
We should either check if the host is already an absolute Uri like we do for other overloads (this PR), or we should throw. socks5://127.0.0.1 is not a valid host, it just happens to be interpreted as:
Host: socks5
Port: : (empty port is allowed and means "default for the scheme"
Path: //127.0.0.1
cc: @ManickaP who noticed our blog posts announcing socks support have broken code snippets.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebProxyhasnew(Uri Address),new(string Address),new(string Host, int Port)constructors that all behave differently.The
new(string)overload will check if the address is an absolute Uri and add a"http://"prefix otherwise.The
new(string, int)overload will blindly concat the host and port$"http://{Host}:{Port}".If you happen to create a
WebProxyobject likenew WebProxy("socks5://127.0.0.1", 9050), what you actually end up with is a proxy to"http://socks5://127.0.0.1:9050"- an http proxy with the hostsocks5and a default port.We should either check if the host is already an absolute Uri like we do for other overloads (this PR), or we should throw.
socks5://127.0.0.1is not a valid host, it just happens to be interpreted as:Host:
socks5Port:
:(empty port is allowed and means "default for the scheme")Path:
//127.0.0.1cc: @ManickaP who noticed our blog posts announcing
sockssupport have broken code snippets.