Remove unused private parameters in SPC

[marek-safar]

and remove related dead code

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

[ghost]

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

---

and remove related dead code

Author:	marek-safar
Assignees:	marek-safar
Labels:	area-System.Runtime
Milestone:	-

[jkotas]

Many instances of this stylecop warning were cleaned up in dotnet/coreclr#26104, but the enforcement was not enabled enforcement as part of that PR. cc @stephentoub

[jkotas]

Some of the similar cases are partial methods. Is there are reason why these are Conditional("unnecessary") and not partial methods?

[marek-safar]

They are not private hence we cannot use a partial method without an implementation.

[stephentoub]

Many instances of this stylecop warning were cleaned up in dotnet/coreclr#26104, but the enforcement was not enabled enforcement as part of that PR. cc @stephentoub

Because there was a lot left to do across the repo :)

[stephentoub]

@marek-safar, are you planning to fix all occurrences of this across the repo and enable the rule?

Otherwise, I'm not a big fan of adding a lot of suppressions for a rule we explicitly disable.

[marek-safar]

are you planning to fix all occurrences of this across the repo and enable the rule?

I'd like in 2022 ;-)

[eerhardt]

LGTM