Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move System.Drawing.Common to SafeHandles et. al. #63085

Closed
wants to merge 15 commits into from
Closed

Move System.Drawing.Common to SafeHandles et. al. #63085

wants to merge 15 commits into from

Commits on Dec 22, 2021

  1. Move the Brush type and its children to SafeHandles. 

    And fix some P/Invoke definitions.
    @teo-tsirpanis
    teo-tsirpanis committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    8f5d5ea View commit details
    Browse the repository at this point in the history

  2. Use [ThreadStatic] in Gdip.ThreadData.

    @teo-tsirpanis
    teo-tsirpanis committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    6762a58 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2021

  1. Move the Pen type to SafeHandles.

    @teo-tsirpanis
    teo-tsirpanis committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    b3acb62 View commit details
    Browse the repository at this point in the history

  2. Fix compilation errors in SolidBrush.

    @teo-tsirpanis
    teo-tsirpanis committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    995a9cd View commit details
    Browse the repository at this point in the history

  3. Use OperatingSystem.IsXxx instead of RuntimeInformation.IsOSPlatform.

    @teo-tsirpanis
    teo-tsirpanis committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    83653bf View commit details
    Browse the repository at this point in the history

  4. Add public parameterless constructors to the SafeHandles.

    @teo-tsirpanis
    teo-tsirpanis committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    79ce7e4 View commit details
    Browse the repository at this point in the history

  5. Rename the Brush's safe handle property to SafeBrushHandle.

    @teo-tsirpanis
    teo-tsirpanis committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    22a7c2a View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2021

  1. Move the Matrix type to SafeHandles.

    @teo-tsirpanis
    teo-tsirpanis committed Dec 24, 2021
    Configuration menu
    Copy the full SHA
    5331e0b View commit details
    Browse the repository at this point in the history

  2. Simplify Pen's disposal. 

    It's sealed and no longer has a finalizer. It does not need the full-blown Dispose pattern.
    @teo-tsirpanis
    teo-tsirpanis committed Dec 24, 2021
    Configuration menu
    Copy the full SHA
    7bcee1b View commit details
    Browse the repository at this point in the history

  3. Move the Region type to SafeHandles.

    @teo-tsirpanis
    teo-tsirpanis committed Dec 24, 2021
    Configuration menu
    Copy the full SHA
    f9cb7af View commit details
    Browse the repository at this point in the history

  4. Fix many tests. 

    Accessing a disposed handle now throws ObjectDisposedException instead of ArgumentException.
    @teo-tsirpanis
    teo-tsirpanis committed Dec 24, 2021
    Configuration menu
    Copy the full SHA
    d8b06bc View commit details
    Browse the repository at this point in the history

  5. .NET Framework still throws ArgumentException when using disposed han… 

    …dles.
    @teo-tsirpanis
    teo-tsirpanis committed Dec 24, 2021
    Configuration menu
    Copy the full SHA
    6d596f7 View commit details
    Browse the repository at this point in the history

  6. Move the GraphicsPath type to SafeHandles. 

    And rename some parameter names in the manually marshalled P/Invoke definitions.
    @teo-tsirpanis
    teo-tsirpanis committed Dec 24, 2021
    Configuration menu
    Copy the full SHA
    6b60b9c View commit details
    Browse the repository at this point in the history

  7. Remove two redundant #ifs. The library is compiled for .NET 6 and 7 o… 

    …nly.
    @teo-tsirpanis
    teo-tsirpanis committed Dec 24, 2021
    Configuration menu
    Copy the full SHA
    f62ec5d View commit details
    Browse the repository at this point in the history

  8. Make Gdi32.DeleteObject more resilient. 

    And shorten SafeMatrixHandle.HasEqualHandle.
    @teo-tsirpanis
    teo-tsirpanis committed Dec 24, 2021
    Configuration menu
    Copy the full SHA
    b96cc32 View commit details
    Browse the repository at this point in the history