Update ComputeHash to remove hash allocations for digest authentication #64005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/ncl Issue Detailsnull
|
gfoidl
reviewed
Jan 19, 2022
| @@ -227,17 +227,25 @@ private static string GetRandomAlphaNumericString() | |||
|
|
|||
| private static string ComputeHash(string data, string algorithm) | |||
| { | |||
| // Disable MD5 insecure warning. | |||
| Span<byte> hashBuffer = stackalloc byte[SHA256.HashSizeInBytes]; // SHA256 is the largest hash produced | |||
| byte[] dataBytes = Encoding.UTF8.GetBytes(data); | |||
There was a problem hiding this comment.
Can this allocation be avoided?
E.g. by using a buffer from the array-pool or stack allocating for smaller data-length.
There was a problem hiding this comment.
Probably. Honestly this whole file has a lot of opportunities to reduce string allocations. I held off on that since I was focusing just on how HashAlgorithm is being used throughout libraries.
MihaZupan
approved these changes
Jan 20, 2022
|
@vcsjones were you planning on making other changes here or is this good to merge? |
|
@MihaZupan looks fine to merge to me, failure is #64389. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can stop creating
HashAlgorithminstances and instead use the one-shots.