Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't build IJW and COM host tests for mono #66400

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

elinor-fung
Copy link
Member

I missed that we had this condition for ijwhost and comhost, which is why the added ijw test fails to build.

if (NOT RUNTIME_FLAVOR STREQUAL Mono)
if(CLR_CMAKE_TARGET_WIN32)
add_subdirectory(comhost)
add_subdirectory(ijwhost)
endif()
endif()

Fixes #66380

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned elinor-fung Mar 9, 2022
@elinor-fung elinor-fung changed the title Don't build IJW and COM tests for mono Don't build IJW and COM host tests for mono Mar 9, 2022
@elinor-fung
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vitek-karas
Copy link
Member

Side note/question: why are we building the native hosting tests and mock for mono? Do we actually run them with a mono based framework (as in testhost produces a working mono based dotnet install?)

@steveisok steveisok self-requested a review March 9, 2022 17:43
@elinor-fung
Copy link
Member Author

elinor-fung commented Mar 9, 2022

Yeah, I was wondering that too (didn't look into it for the purposes of just getting this fix). I think the answer is that we don't need to and can just exclude everything in corehost/test - will check on that after this.

@steveisok
Copy link
Member

Side note/question: why are we building the native hosting tests and mock for mono? Do we actually run them with a mono based framework (as in testhost produces a working mono based dotnet install?)

There are community based configurations that only have mono as the runtime (s390x, for example). I think we still need this.

@elinor-fung
Copy link
Member Author

The configurations actually run the installer/host tests? I know we need the host product itself, but for tests, I'm pretty sure a number of them aren't supported for mono (COM, startup hooks) and I don't think the tests do anything to exclude themselves from being run on mono.

@steveisok
Copy link
Member

The configurations actually run the installer/host tests?

I took a closer look and I don't think we run the installer/host tests.

@elinor-fung
Copy link
Member Author

Windows x64 Mono leg passed. Other extra-platforms failures are unrelated.

Faliures in runtime pipeline are:

@elinor-fung elinor-fung merged commit d4f7ef4 into dotnet:main Mar 9, 2022
@elinor-fung elinor-fung deleted the fixBuild branch March 9, 2022 22:16
@ghost ghost locked as resolved and limited conversation to collaborators Apr 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[windows][x64] Build failed in CI
3 participants