Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement System.Decimal.Scale #66403

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Implement System.Decimal.Scale #66403

merged 1 commit into from
Mar 10, 2022

Conversation

MichalPetryka
Copy link
Contributor

Adds System.Decimal.Scale, a property that
returns the scaling factor of the decimal.

Closes #65074.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Mar 9, 2022
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Mar 9, 2022

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

Adds System.Decimal.Scale, a property that
returns the scaling factor of the decimal.

Closes #65074.

Author: MichalPetryka
Assignees: -
Labels:

area-System.Runtime, new-api-needs-documentation, community-contribution
Milestone: -

deeprobin
deeprobin approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@deeprobin deeprobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichalPetryka
Implement System.Decimal.Scale
4f1ba96 
Adds System.Decimal.Scale, a property that
returns the scaling factor of the decimal.

Closes dotnet#65074.
@danmoseley danmoseley merged commit 4ba076e into dotnet:main Mar 10, 2022
@danmoseley
Copy link
Member

Thanks for the contribution @MichalPetryka . BTW as a small nit, it is ideal to not do a force push after the review, as everything must be re-reviewed rather than just any new changes since the review. Of course in this change that is easy for us.

@ghost ghost locked as resolved and limited conversation to collaborators Apr 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deeprobin deeprobin deeprobin approved these changes

@tannergooding tannergooding tannergooding approved these changes

Assignees
No one assigned
Labels
area-System.Runtime community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Scale property for the decimal datatype
4 participants
@MichalPetryka @danmoseley @deeprobin @tannergooding