Support virtualized 32-bit build on 64-bit ARM cores #66438
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
added
the
community-contribution
akoeplinger
requested review from
lambdageek,
vargaz,
BrzVlad,
naricc,
SamMonoRT,
lateralusX,
thaystg,
marek-safar and
MichalStrehovsky
as code owners
akoeplinger
removed request for
vargaz,
marek-safar,
lambdageek,
thaystg,
BrzVlad,
lateralusX,
MichalStrehovsky,
naricc and
SamMonoRT
|
@ayakael we don't target PRs to release/6.0 directly, they need to go into main first. I tried changing the branch via GitHub's UI but that messed up the commits. Please open a new PR which targets the |
|
Oh, sorry about that! Done! #66477 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected behavior
Runtime should be able to build within 32-bit userspace on 64-bit ARM cores.
Actual behavior
Per dotnet/source-build#2781, runtime does not know to parse as
armwhen output ofuname -misarmv8l.Proposed modifications
This pull request modifies existing logics to parse
armv8lin the same way asarmv7l.Varia
Parallel merge request on Alpine's side
Arm support on source-build at dotnet/installer#13378
Made as part of Alpine Linux dotnet6 packaging project, see dotnet/source-build#2782