-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Managed implementation of NTLM for Android and tvOS #66879
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
f4e853f
Move MD4 implementation into Common/src/System/Net/Security
filipnavara b87aeb5
Add minimal RC4 implementation
filipnavara f9b6145
WIP: Integrate managed Ntlm implementation into SocketsHttpHandler
filipnavara dc67cce
WIP: Makeshift tests for NTLM/Negotiate authentication
filipnavara 5f19f56
Fix compilation, clean up some of the hashing
filipnavara 7980fad
Avoid using a temporary buffer
filipnavara a26196e
Add computation of signing keys, sealing keys and mechListMIC
filipnavara afe1b86
Various cleanups
filipnavara 9234395
Send SPN in target information
filipnavara f81f048
Add some validation, mark spots with missing validation
filipnavara a531394
Clean up some of the memory offset manipulation
filipnavara de945b8
Move NTLM version into static variable
filipnavara e185050
Add support for channel bindings, clean up
filipnavara 9e66fcb
Fix hash calculation in makeNtlm2Hash accidentally broken with last c…
filipnavara d6364a3
Verify last authentication token in HTTP Negotiate authentication
filipnavara 4d10cfa
Address feedback
filipnavara 56029d3
Fix tvOS builds by making few methods static
filipnavara 50a8fc6
Enable System.Net.Security tests on Android and iOS
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
955 changes: 955 additions & 0 deletions
955
src/libraries/Common/src/System/Net/NTAuthentication.Managed.cs
Large diffs are not rendered by default.
Oops, something went wrong.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| // | ||
| // ARC4Managed.cs: Alleged RC4(tm) compatible symmetric stream cipher | ||
| // RC4 is a trademark of RSA Security | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining | ||
| // a copy of this software and associated documentation files (the | ||
| // "Software"), to deal in the Software without restriction, including | ||
| // without limitation the rights to use, copy, modify, merge, publish, | ||
| // distribute, sublicense, and/or sell copies of the Software, and to | ||
| // permit persons to whom the Software is furnished to do so, subject to | ||
| // the following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be | ||
| // included in all copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, | ||
| // EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF | ||
| // MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND | ||
| // NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE | ||
| // LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION | ||
| // OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION | ||
| // WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
| // | ||
|
|
||
| using System; | ||
| using System.Buffers; | ||
| using System.Diagnostics; | ||
| using System.Security.Cryptography; | ||
|
|
||
| namespace System.Net.Security | ||
| { | ||
| // References: | ||
| // a. Usenet 1994 - RC4 Algorithm revealed | ||
| // http://www.qrst.de/html/dsds/rc4.htm | ||
| internal class RC4 : IDisposable | ||
| { | ||
| private byte[]? state; | ||
| private byte x; | ||
| private byte y; | ||
|
|
||
| public RC4(ReadOnlySpan<byte> key) | ||
| { | ||
| state = ArrayPool<byte>.Shared.Rent(256); | ||
|
|
||
| byte index1 = 0; | ||
| byte index2 = 0; | ||
|
|
||
| for (int counter = 0; counter < 256; counter++) | ||
| { | ||
| state[counter] = (byte)counter; | ||
| } | ||
|
|
||
| for (int counter = 0; counter < 256; counter++) | ||
| { | ||
| index2 = (byte)(key[index1] + state[counter] + index2); | ||
| (state[counter], state[index2]) = (state[index2], state[counter]); | ||
| index1 = (byte)((index1 + 1) % key.Length); | ||
| } | ||
| } | ||
|
|
||
| public void Dispose() | ||
| { | ||
| if (state != null) | ||
| { | ||
| x = 0; | ||
| y = 0; | ||
| CryptographicOperations.ZeroMemory(state.AsSpan(0, 256)); | ||
| ArrayPool<byte>.Shared.Return(state); | ||
| state = null; | ||
| } | ||
| } | ||
|
|
||
| public void Transform(ReadOnlySpan<byte> input, Span<byte> output) | ||
| { | ||
| Debug.Assert(input.Length == output.Length); | ||
| Debug.Assert(state != null); | ||
|
|
||
| for (int counter = 0; counter < input.Length; counter++) | ||
| { | ||
| x = (byte)(x + 1); | ||
| y = (byte)(state[x] + y); | ||
| (state[x], state[y]) = (state[y], state[x]); | ||
| byte xorIndex = (byte)(state[x] + state[y]); | ||
| output[counter] = (byte)(input[counter] ^ state[xorIndex]); | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks to me like Transform is only ever called once on any given instance. Rather than an instantiable class, this should just be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the case for the MIC calculation but it would be reused for Encrypt/Decrypt if we implement it later (for SMTP authentication and NegotiateStream).