Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable recently added analyzers (and fix some violations) #67292

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Enable recently added analyzers (and fix some violations) #67292

merged 1 commit into from
Mar 30, 2022

Conversation

stephentoub
Copy link
Member

@ghost ghost assigned stephentoub Mar 29, 2022
@ghost
Copy link

ghost commented Mar 29, 2022

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

cc: @jkoritzinsky, @buyaa-n, @Cosifne

Author: stephentoub
Assignees: stephentoub
Labels:

area-Meta
Milestone: -

buyaa-n
buyaa-n approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@stephentoub
Copy link
Member Author

Failure is #60962

@stephentoub stephentoub merged commit b2e494c into dotnet:main Mar 30, 2022
@stephentoub stephentoub deleted the enablenewrules branch March 30, 2022 10:55
@ghost ghost locked as resolved and limited conversation to collaborators Apr 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky left review comments

@danmoseley danmoseley danmoseley left review comments

@gregg-miskelly gregg-miskelly gregg-miskelly left review comments

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT left review comments

@Cosifne Cosifne Cosifne approved these changes

@buyaa-n buyaa-n buyaa-n approved these changes

Assignees

@stephentoub stephentoub

Labels
area-Meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@stephentoub @jkoritzinsky @danmoseley @gregg-miskelly @Cosifne @AaronRobinsonMSFT @buyaa-n