[wasm][debugger] Fix a randomly failing JS test #67945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`DebuggerTests.ExceptionTests.JSExceptionTestAll` can some times fail
with:
```
[xUnit.net 00:01:08.51] DebuggerTests.ExceptionTests.JSExceptionTestAll [FAIL]
Failed DebuggerTests.ExceptionTests.JSExceptionTestAll [105 ms]
Error Message:
[{
"callFrameId": "-2618252572970282349.1.0",
"functionName": "lookup",
...
Expected: exception_caught_test
Actual: lookup
Stack Trace:
at DebuggerTests.DebuggerTestBase.AssertEqual(Object expected, Object actual, String label) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 1119
at DebuggerTests.DebuggerTestBase.SendCommandAndCheck(JObject args, String method, String script_loc, Int32 line, Int32 column, String function_name, Func`2 wait_for_event_fn, Func`2 locals_fn, String waitForEvent) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 562
at DebuggerTests.DebuggerTestBase.EvaluateAndCheck(String expression, String script_loc, Int32 line, Int32 column, String function_name, Func`2 wait_for_event_fn, Func`2 locals_fn) in /_/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 542
at DebuggerTests.ExceptionTests.JSExceptionTestAll() in /_/src/mono/wasm/debugger/DebuggerTestSuite/ExceptionTests.cs:line 70
```
This test is set to pause on every exception thrown, but the test
assumes that the first exception that it gets will be the expected one.
But we can get other JS exceptions before that. So, wait for the correct
one, while ignoring any *js* ones.
|
Tagging subscribers to 'arch-wasm': @lewing Issue Details
This test is set to pause on every exception thrown, but the test
|
This was referenced Apr 13, 2022
Closed
ilonatommy
approved these changes
Apr 13, 2022
lewing
approved these changes
Apr 22, 2022
|
Failure is unrelated |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DebuggerTests.ExceptionTests.JSExceptionTestAllcan some times failwith:
This test is set to pause on every exception thrown, but the test
assumes that the first exception that it gets will be the expected one.
But we can get other JS exceptions before that. So, wait for the correct
one, while ignoring any other js ones.