Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix placeholder files in packages #67960

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Fix placeholder files in packages #67960

merged 1 commit into from
Apr 13, 2022

Conversation

ViktorHofer
Copy link
Member

Reported in #67647 (comment). Accidentally got the package path wrong for placeholder files and didn't notice it locally.

@ghost
Copy link

ghost commented Apr 13, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Reported in #67647 (comment). Accidentally got the package path wrong for placeholder files and didn't notice it locally.

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure-libraries

Milestone: -

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@am11
Copy link
Member

am11 commented Apr 13, 2022

Thanks for the quick fix. Should we fix these instances as well:

% git grep 'PackagePath.*targets"'
eng/packaging.targets:      <Content Include="$(MultiTargetRoslynComponentTargetsFileIntermediatePath)" PackagePath="buildTransitive\netstandard2.0\$(PackageId).targets" />
eng/packaging.targets:      <Content Include="$(MultiTargetRoslynComponentTargetsFileIntermediatePath)" PackagePath="buildTransitive\%(NETStandardCompatError.Supported)\$(PackageId).targets" Condition="'@(NETStandardCompatError)' != ''" />
eng/packaging.targets:            PackagePath="buildTransitive\%(NETStandardCompatError.Identity)\$(PackageId).targets"
eng/packaging.targets:            PackagePath="$(_NETStandardCompatErrorPlaceholderFilePackagePath)\$(PackageId).targets"
src/libraries/System.Resources.Extensions/src/System.Resources.Extensions.csproj:               PackagePath="buildTransitive\$(NetFrameworkMinimum)\$(PackageId).targets" />

Apparently PackagePath with forward slashes accepts filename as well as directory name (based on trailing slash), but with backslashes it considers the value as directory (NuGet/Home#6351).

@ViktorHofer
Copy link
Member Author

Should we fix these instances as well

I tested the packages and the cases that you pointed out work fine. I don't think there's anything to fix there. Can you please elaborate which kind of issues you are seeing? :)

@am11
Copy link
Member

am11 commented Apr 13, 2022

I tested the packages and the cases that you pointed out work fine.

Cool. I just skimmed through #67647 diff and thought the other similar places (with filename in PackagePath value) also need this change. If it works to unblock the codeflow, :shipit: 👍

@ViktorHofer ViktorHofer merged commit 12dd2ab into main Apr 13, 2022
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-1 branch April 13, 2022 17:30
@ghost ghost locked as resolved and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants