Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dnceng/internal/dotnet-optimization #68109

Merged
merged 1 commit into from
Apr 16, 2022

Conversation

dotnet-maestro[bot]
Copy link
Contributor

This pull request updates the following dependencies

From https://dev.azure.com/dnceng/internal/_git/dotnet-optimization

  • Subscription: d3a5b203-1393-4534-5b62-08d8d8feb47e
  • Build: 20220415.3
  • Date Produced: April 15, 2022 11:09:11 PM UTC
  • Commit: 75d314fa7aa6bdce4d84473269fb6f22fb93b62d
  • Branch: refs/heads/main

…otnet-optimization build 20220415.3

optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.22121.2 -> To Version 1.0.0-prerelease.22215.3
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Apr 16, 2022
@EgorBo
Copy link
Member

EgorBo commented Apr 16, 2022

Finally 😐

@am11
Copy link
Member

am11 commented Apr 16, 2022

@EgorBo, what do you think about adding {M}IBC to glossary. To my understanding:

--- a/docs/project/glossary.md
+++ b/docs/project/glossary.md
@@ -24,12 +24,14 @@ terminology.
 | DAC | Data Access Component. An abstraction layer over the internal structures in the runtime. |
 | EE | [Execution Engine](https://docs.microsoft.com/dotnet/standard/managed-execution-process#running_code). |
 | GC | [Garbage Collector](https://github.com/dotnet/runtime/blob/main/docs/design/coreclr/botr/garbage-collection.md). |
+| IBC | Instrumented Block Counts - used as extension (`*.ibc`) for old PGO files. |
 | IPC | Inter-Process Communication. |
 | IL | Intermediate Language. Equivalent to CIL, also equivalent to [MSIL](https://docs.microsoft.com/dotnet/standard/managed-execution-process#compiling-to-msil). |
 | JIT | [Just-in-Time](https://github.com/dotnet/runtime/blob/main/docs/design/coreclr/jit/ryujit-overview.md) compiler. RyuJIT is the code name for the next generation Just-in-Time(aka "JIT") for the .NET runtime. |
 | LCG | Lightweight Code Generation. An early name for [dynamic methods](https://github.com/dotnet/runtime/blob/main/src/coreclr/System.Private.CoreLib/src/System/Reflection/Emit/DynamicMethod.cs). |
 | MD | MetaData. |
 | MDA | Managed Debugging Assistant - see [details](https://docs.microsoft.com/dotnet/framework/debug-trace-profile/diagnosing-errors-with-managed-debugging-assistants) (Note: Not in .NET Core, equivalent diagnostic functionality is made available on a case-by-case basis, e.g. [#9418](https://github.com/dotnet/runtime/issues/9418)) |
+| MIBC | Modern Instrumented Block Counts - used as extension (`*.mibc`) for modern PGO files. |
 | MSIL | [Microsoft Intermediate Language](https://docs.microsoft.com/dotnet/standard/managed-execution-process#compiling-to-msil).Common Intermediate Language. Equivalent to IL, also equivalent to CIL. |
 | NGen | Native Image Generator. |
 | NYI | Not Yet Implemented. |

@EgorBo
Copy link
Member

EgorBo commented Apr 16, 2022

@EgorBo, what do you think about adding {M}IBC to glossary. To my understanding:

--- a/docs/project/glossary.md
+++ b/docs/project/glossary.md
@@ -24,12 +24,14 @@ terminology.
 | DAC | Data Access Component. An abstraction layer over the internal structures in the runtime. |
 | EE | [Execution Engine](https://docs.microsoft.com/dotnet/standard/managed-execution-process#running_code). |
 | GC | [Garbage Collector](https://github.com/dotnet/runtime/blob/main/docs/design/coreclr/botr/garbage-collection.md). |
+| IBC | Instrumented Block Counts - used as extension (`*.ibc`) for old PGO files. |
 | IPC | Inter-Process Communication. |
 | IL | Intermediate Language. Equivalent to CIL, also equivalent to [MSIL](https://docs.microsoft.com/dotnet/standard/managed-execution-process#compiling-to-msil). |
 | JIT | [Just-in-Time](https://github.com/dotnet/runtime/blob/main/docs/design/coreclr/jit/ryujit-overview.md) compiler. RyuJIT is the code name for the next generation Just-in-Time(aka "JIT") for the .NET runtime. |
 | LCG | Lightweight Code Generation. An early name for [dynamic methods](https://github.com/dotnet/runtime/blob/main/src/coreclr/System.Private.CoreLib/src/System/Reflection/Emit/DynamicMethod.cs). |
 | MD | MetaData. |
 | MDA | Managed Debugging Assistant - see [details](https://docs.microsoft.com/dotnet/framework/debug-trace-profile/diagnosing-errors-with-managed-debugging-assistants) (Note: Not in .NET Core, equivalent diagnostic functionality is made available on a case-by-case basis, e.g. [#9418](https://github.com/dotnet/runtime/issues/9418)) |
+| MIBC | Modern Instrumented Block Counts - used as extension (`*.mibc`) for modern PGO files. |
 | MSIL | [Microsoft Intermediate Language](https://docs.microsoft.com/dotnet/standard/managed-execution-process#compiling-to-msil).Common Intermediate Language. Equivalent to IL, also equivalent to CIL. |
 | NGen | Native Image Generator. |
 | NYI | Not Yet Implemented. |

good idea, feel free to file a PR 🙂

@EgorBo EgorBo merged commit 4301bb2 into main Apr 16, 2022
@dotnet-maestro dotnet-maestro bot deleted the darc-main-376782bc-499b-4c2b-a39f-2b296f0da803 branch April 16, 2022 22:15
@dakersnar
Copy link
Contributor

This may have caused some regressions on Windows x86 dotnet/perf-autofiling-issues#4707

@dakersnar
Copy link
Contributor

More regressions
image

System.Collections.ContainsTrue.Span(Size: 512)

Result Ratio Operating System Bit Processor Name
Slower 0.88 ubuntu 20.04 Arm64 Unknown processor
Slower 0.88 Windows 10 Arm64 Microsoft SQ1 3.0 GHz
Slower 0.89 Windows 11 Arm64 Microsoft SQ1 3.0 GHz
Slower 0.88 Windows 11 Arm64 Unknown processor
Same 1.00 macOS Monterey 12.3 Arm64 Apple M1 Max
Same 0.90 Windows 10 X64 Intel Xeon Platinum 8272CL CPU 2.60GHz
Slower 0.86 Windows 10 X64 Intel Xeon CPU E5-1650 v4 3.60GHz
Same 0.98 Windows 10 X64 Intel Core i7-6700 CPU 3.40GHz (Skylake)
Slower 0.73 Windows 11 X64 AMD Ryzen Threadripper PRO 3945WX 12-Cores
Slower 0.77 Windows 11 X64 AMD Ryzen 9 5950X
Same 0.96 Windows 11 X64 Intel Core i7-8700 CPU 3.20GHz (Coffee Lake)
Same 0.98 Windows 11 X64 Intel Core i9-9900T CPU 2.10GHz
Same 0.94 alpine 3.13 X64 Intel Core i7-7700 CPU 3.60GHz (Kaby Lake)
Same 0.99 pop 22.04 X64 Intel Core i7-6600U CPU 2.60GHz (Skylake)
Slower 0.77 ubuntu 18.04 X64 Intel Xeon CPU E5-1650 v4 3.60GHz
Same 0.97 ubuntu 18.04 X64 Intel Core i7-2720QM CPU 2.20GHz (Sandy Bridge)
Same 0.90 ubuntu 20.04 X64 AMD Ryzen 9 5900X
Slower 0.76 ubuntu 20.04 X64 Intel Core i7-8700 CPU 3.20GHz (Coffee Lake)
Slower 0.86 Windows 10 X86 Intel Xeon CPU E5-1650 v4 3.60GHz
Same 1.01 Windows 10 X86 Intel Core i7-6700 CPU 3.40GHz (Skylake)
Slower 0.84 Windows 11 X86 AMD Ryzen Threadripper PRO 3945WX 12-Cores
Slower 0.80 macOS Monterey 12.2.1 X64 Intel Core i7-5557U CPU 3.10GHz (Broadwell)
Slower 0.88 macOS Monterey 12.3.1 X64 Intel Core i7-4870HQ CPU 2.50GHz (Haswell)

@ghost ghost locked as resolved and limited conversation to collaborators Jun 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants