Cleanup ProjectN references #68201
Merged
Cleanup ProjectN references #68201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-reflection Issue Detailsnull
|
danmoseley
approved these changes
Apr 19, 2022
...reclr/nativeaot/System.Private.DisabledReflection/src/Internal/Reflection/RuntimeTypeInfo.cs
Show resolved
Hide resolved
...oreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/ArgIterator.cs
Show resolved
Hide resolved
MichalStrehovsky
approved these changes
Apr 19, 2022
| // The ILC toolchain fails the build if it encounters such a type. | ||
| // This api is a nop unless the array element type is a value type with an explicit nullary constructor. | ||
| // Such a type could not be expressed in C# up until recently. | ||
| // The AOT toolchain fails the build if it encounters such a type. |
There was a problem hiding this comment.
ProjectN does fail the build if it sees a parameterless ctor on a valuetype, but NativeAOT doesn't we just silently don't do the right thing.
jkotas
commented
Apr 19, 2022
src/coreclr/nativeaot/System.Private.CoreLib/src/System/Array.CoreRT.cs
Outdated
Show resolved
Hide resolved
directhex
pushed a commit
to directhex/runtime
that referenced
this pull request
Apr 21, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.