Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat INDEX as a potentially throwing operation #68381

Merged
merged 2 commits into from
Apr 22, 2022
Merged

Treat INDEX as a potentially throwing operation #68381

merged 2 commits into from
Apr 22, 2022

Conversation

SingleAccretion
Copy link
Contributor

Not doing so can lead to early dead code elimination dropping it.

@SingleAccretion
Treat INDEX as potentially throwing
6b69b7e 
Not doing so will lead to the side-effect extraction routine dropping it.
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Apr 22, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 22, 2022
@ghost
Copy link

ghost commented Apr 22, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Not doing so can lead to early dead code elimination dropping it.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@SingleAccretion SingleAccretion force-pushed the Fix-OperMayThrow-For-Index-Xunit branch 2 times, most recently from 1a1760c to e624c7b Compare April 22, 2022 10:08
@SingleAccretion SingleAccretion changed the title Treate INDEX as a potentially throwing operation Treat INDEX as a potentially throwing operation Apr 22, 2022
@SingleAccretion SingleAccretion force-pushed the Fix-OperMayThrow-For-Index-Xunit branch from e624c7b to ec5f2a8 Compare April 22, 2022 10:14
@runfoapp runfoapp bot mentioned this pull request Apr 22, 2022
Closed
@SingleAccretion
Copy link
Contributor Author

Linux_musl x64 Debug failure is #59542.

Diffs are the expected set of new INDEXes altering the output (including with new CSEs and the like).

@SingleAccretion SingleAccretion marked this pull request as ready for review April 22, 2022 19:35
@SingleAccretion
Copy link
Contributor Author

@dotnet/jit-contrib

@BruceForstall BruceForstall merged commit a1c61fd into dotnet:main Apr 22, 2022
@SingleAccretion SingleAccretion deleted the Fix-OperMayThrow-For-Index-Xunit branch April 23, 2022 10:41
@ghost ghost locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BruceForstall BruceForstall BruceForstall approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SingleAccretion @BruceForstall