Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Docker images from mcr.microsoft.com in EnterpriseTests #68875

Merged
merged 1 commit into from
May 5, 2022

Conversation

akoeplinger
Copy link
Member

We started getting warnings in the build about using images from docker directly, see https://docs.opensource.microsoft.com/tools/nuget_security_analysis/container_registry_analysis/

The image from dotnet-buildtools-prereqs-docker can be used instead.

We started getting warnings in the build about using images from docker directly, see https://docs.opensource.microsoft.com/tools/nuget_security_analysis/container_registry_analysis/

The image from dotnet-buildtools-prereqs-docker can be used instead.
@akoeplinger akoeplinger requested a review from wfurt May 4, 2022 22:36
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented May 4, 2022

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

We started getting warnings in the build about using images from docker directly, see https://docs.opensource.microsoft.com/tools/nuget_security_analysis/container_registry_analysis/

The image from dotnet-buildtools-prereqs-docker can be used instead.

Author: akoeplinger
Assignees: akoeplinger
Labels:

area-System.Net.Security

Milestone: -

@@ -1,4 +1,4 @@
FROM ubuntu:18.04
FROM mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-20220421022739-9c434db
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no mcr version of ubuntu with the floating tag? Or is there a better image to use that rolls in any of the vetted registries?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, there isn't a floating version on mcr. we're already using this image in a couple other places in the build.

@wfurt
Copy link
Member

wfurt commented May 5, 2022

Can you run the enterprise pipeline on this @MattGal? It would be nice not to make changes while the pipeline is disabled.

@akoeplinger
Copy link
Member Author

/azp run runtime-libraries enterprise-linux

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dotnet dotnet deleted a comment from azure-pipelines bot May 5, 2022
@akoeplinger
Copy link
Member Author

https://dev.azure.com/dnceng/public/_build/results?buildId=1753553&view=ms.vss-test-web.build-test-results-tab has the same test failure as the last PR build of the enterprise pipeline so should be fine.

Merging to get rid of the warnings.

@akoeplinger akoeplinger merged commit bafae1b into dotnet:main May 5, 2022
@akoeplinger akoeplinger deleted the enterprisetests-docker branch May 5, 2022 12:58
akoeplinger added a commit to akoeplinger/runtime that referenced this pull request May 5, 2022
…8875)

We started getting warnings in the build about using images from docker directly, see https://docs.opensource.microsoft.com/tools/nuget_security_analysis/container_registry_analysis/

The image from dotnet-buildtools-prereqs-docker can be used instead.

(cherry picked from commit bafae1b)
carlossanlop pushed a commit that referenced this pull request May 16, 2022
…68913)

* attempt to fix up EnterpriseTests (#65981)

* attemp to fix up EnterpriseTests

* fix text

* increase timoeout on build step

* fix temeout

* add jobs

* update job

* fix formating

* fix name

* update server check

* restore original resolver before tests

* fix path

* experiment

(cherry picked from commit 9174037)

* upgrade docker to get clang9 to prevent coreclr crashes (#68311)

(cherry picked from commit edb9c49)

* Use Docker images from mcr.microsoft.com in EnterpriseTests (#68875)

We started getting warnings in the build about using images from docker directly, see https://docs.opensource.microsoft.com/tools/nuget_security_analysis/container_registry_analysis/

The image from dotnet-buildtools-prereqs-docker can be used instead.

(cherry picked from commit bafae1b)

Co-authored-by: Tomas Weinfurt <tweinfurt@yahoo.com>
@ghost ghost locked as resolved and limited conversation to collaborators Jun 4, 2022
@karelz karelz added this to the 7.0.0 milestone Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants