Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: minor enhancement to jump threading #69022

Conversation

AndyAyersMS
Copy link
Member

Allow jump threading of branches with exceptions, provided the branch and the
dominating branch are in the same EH region.

Allow jump threading of branches with exceptions, provided the branch and the
dominating branch are in the same EH region.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 8, 2022
@ghost ghost assigned AndyAyersMS May 8, 2022
@ghost
Copy link

ghost commented May 8, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Allow jump threading of branches with exceptions, provided the branch and the
dominating branch are in the same EH region.

Author: AndyAyersMS
Assignees: AndyAyersMS
Labels:

area-CodeGen-coreclr

Milestone: -

@AndyAyersMS
Copy link
Member Author

@jakobbotsch PTAL
cc @dotnet/jit-contrib

Small enhancement I noticed while looking at other things.

There is one bad diff in ASP.NET SPMI, looks like removing branches / slightly different block order makes life harder for LSRA somehow.

121 ( 3.32% of base) : 37961.dasm - RelationshipDiscoveryConvention:RemoveIncompatibleWithExistingRelationships(IReadOnlyList`1,IConventionEntityTypeBuilder):IReadOnlyList`1

@AndyAyersMS
Copy link
Member Author

DDARM64-147 seems to be failing lots of jobs. Build Analysis doesn't pick up this kind of problem, evidently.

Console log: 'JIT.PGO' from job e7b0629f-8fb6-45f7-bfa7-23c80f5ef456 workitem ea0ce30a-9d42-4aac-af71-c0109c301cb6 (windows.10.arm64v8.open) executed on machine

@AndyAyersMS AndyAyersMS merged commit 390620f into dotnet:main May 9, 2022
@dotnet dotnet locked as resolved and limited conversation to collaborators Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants