Remove an allocation during RSA key generation #69024
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating an RSA key, we are creating a
CngProperty
. SinceCngProperty
always created a defensive copy of data, this adds an internal constructor that accepts aReadOnlySpan<byte>
and copies it, with the added benefit that the source doesn't have to be abyte[]
already.So this effectively changes a
new byte[4]
to astackalloc byte[4]
.This also removes a full null checks that were not required.