Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds #69264

Merged
merged 1 commit into from
May 13, 2022

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented May 12, 2022

fixes #60190.

The test was failing with AuthenticationException because the certificates expired.
E.g. this is not the typical network availability flakiness.
Since the cert is updated, I'm simply enabling the test again.

    Discovering: System.Net.Http.Functional.Tests (method display = ClassAndMethod, method display options = None)
    Discovered:  System.Net.Http.Functional.Tests (found 1 of 1624 test case)
    Starting:    System.Net.Http.Functional.Tests (parallel test collections = on, max threads = 16)
      System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_ServerCertificates_Test.NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds [STARTING]
  CP CreateHttp11ConnectionAsync called True
  ConnectToTcpHostAsync: connecting to Unspecified/revoked.badssl.com:443 5/12/2022 10:25:06 AM
      System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_ServerCertificates_Test.NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds [FINISHED] Time: 1.0130356s
    Finished:    System.Net.Http.Functional.Tests
  === TEST EXECUTION SUMMARY ===
     System.Net.Http.Functional.Tests  Total: 1, Errors: 0, Failed: 0, Skipped: 0, Time: 1.109s

@wfurt wfurt requested a review from a team May 12, 2022 17:29
@wfurt wfurt self-assigned this May 12, 2022
@ghost
Copy link

ghost commented May 12, 2022

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

fixes #60190.

The test was failing with AuthenticationException because the certificates expired.
E.g. this is not the typical network availability flakiness.
Since the cert is updated, I'm simply enabling the test again.

    Discovering: System.Net.Http.Functional.Tests (method display = ClassAndMethod, method display options = None)
    Discovered:  System.Net.Http.Functional.Tests (found 1 of 1624 test case)
    Starting:    System.Net.Http.Functional.Tests (parallel test collections = on, max threads = 16)
      System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_ServerCertificates_Test.NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds [STARTING]
  CP CreateHttp11ConnectionAsync called True
  ConnectToTcpHostAsync: connecting to Unspecified/revoked.badssl.com:443 5/12/2022 10:25:06 AM
      System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_ServerCertificates_Test.NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds [FINISHED] Time: 1.0130356s
    Finished:    System.Net.Http.Functional.Tests
  === TEST EXECUTION SUMMARY ===
     System.Net.Http.Functional.Tests  Total: 1, Errors: 0, Failed: 0, Skipped: 0, Time: 1.109s
Author: wfurt
Assignees: wfurt
Labels:

area-System.Net.Security

Milestone: -

@wfurt
Copy link
Member Author

wfurt commented May 12, 2022

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wfurt
Copy link
Member Author

wfurt commented May 13, 2022

many failing tests but NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds was ok.

@wfurt wfurt merged commit 0615148 into dotnet:main May 13, 2022
@wfurt wfurt deleted the badssl branch May 13, 2022 21:36
@ghost ghost locked as resolved and limited conversation to collaborators Jun 13, 2022
@karelz karelz added this to the 7.0.0 milestone Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds
3 participants