Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the shared framework build uses the generated runtime.json #69455

Closed
wants to merge 1 commit into from

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented May 17, 2022

Fixes #53550

@@ -221,6 +221,6 @@
ResolveLibrariesRuntimeFilesFromLocalBuild" />

<PropertyGroup>
<BundledRuntimeIdentifierGraphFile>$(RuntimeIdGraphDefinitionFile)</BundledRuntimeIdentifierGraphFile>
<BundledRuntimeIdentifierGraphFile>$(LiveRuntimeIdGraphDefinitionFile)</BundledRuntimeIdentifierGraphFile>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By switching to the live generated runtime.json file, you are depending on the file already being generated which isn't the case until the Microsoft.NETCore.Platforms project is built. We should make sure that any code path that depends on it has a dependency to the Platforms project.

@ericstj
Copy link
Member Author

ericstj commented Sep 21, 2022

Closing this as I don't have cycles to drive it at the moment. @tmds feel free to fix this as it best fits the work you're doing.

@ericstj ericstj closed this Sep 21, 2022
@tmds
Copy link
Member

tmds commented Sep 22, 2022

@ericstj the minimal thing we need for source-build is: have the non-portable rid show up in $DOTNET_ROOT/shared/Microsoft.NETCore.App/7.0.0/Microsoft.NETCore.App.deps.json.
Do you know where this file gets generated? Can we apply a patch so that picks up the runtime.json file from Microsoft.NETCore.Platforms.csproj?

@ericstj
Copy link
Member Author

ericstj commented Sep 22, 2022

There are two places that generate a shared framework deps file. One is pretest.proj which is used by library testing.

RuntimeGraphFiles="$(RuntimeIdGraphDefinitionFile)"

The other is the shared framework SDK which uses the BundledRuntimeIdentifierGraphFile property https://github.com/dotnet/arcade/blob/9bbfa8dbc89c406eb8e2bc62600a007882ccd0ab/src/Microsoft.DotNet.SharedFramework.Sdk/targets/sharedfx.targets#L197
This is the one the is used inside the final shared-framework / runtime-packs cc @jkoritzinsky @NikolaMilosavljevic

@ghost ghost locked as resolved and limited conversation to collaborators Oct 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure shared framework consumes source-built RID graph
3 participants