Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IsSupported guard check for use of Ssse3.Shuffle in Span.Reverse #69623

Merged
merged 1 commit into from
May 21, 2022

Conversation

AndyAyersMS
Copy link
Member

We were checking for SSE2 support and then using SSSE3 instructions.

Fixes #68880.

We were checking for SSE2 support and then using SSSE3 instructions.

Fixes dotnet#68880.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 20, 2022
@AndyAyersMS
Copy link
Member Author

@adamsitnik @tannergooding PTAL

@ghost ghost assigned AndyAyersMS May 20, 2022
@ghost
Copy link

ghost commented May 20, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

We were checking for SSE2 support and then using SSSE3 instructions.

Fixes #68880.

Author: AndyAyersMS
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@AndyAyersMS AndyAyersMS merged commit 3b2f833 into dotnet:main May 21, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jun 20, 2022
@adamsitnik adamsitnik added this to the 7.0.0 milestone Jun 22, 2022
@adamsitnik
Copy link
Member

@AndyAyersMS thank you for providing the fix!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure Interop\\COM\\NETClients\\Primitives\\NETClientPrimitivesInALC\\NETClientPrimitivesInALC.cmd
4 participants