Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double to Decimal Conversion Refactor (WIP) #70602

Closed
wants to merge 32 commits into from
Closed

Double to Decimal Conversion Refactor (WIP) #70602

wants to merge 32 commits into from

Commits on May 3, 2022

  1. WIP: decimal conversion bug

    @dakersnar
    dakersnar committed May 3, 2022
    Configuration menu
    Copy the full SHA
    391f805 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/dotnet/runtime into fix-68042

    @dakersnar
    dakersnar committed May 3, 2022
    Configuration menu
    Copy the full SHA
    a6dc156 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of https://github.com/dotnet/runtime into fix-68042

    @dakersnar
    dakersnar committed May 3, 2022
    Configuration menu
    Copy the full SHA
    edc3f67 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of https://github.com/dotnet/runtime into fix-68042

    @dakersnar
    dakersnar committed May 3, 2022
    Configuration menu
    Copy the full SHA
    cccae84 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2022

  1. Merge branch 'fix-68042' of https://github.com/dakersnar/runtime into… 

    … fix-68042
    @dakersnar
    dakersnar committed May 9, 2022
    Configuration menu
    Copy the full SHA
    5a19f23 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2022

  1. Split up Dragon4 into two parts in order to reuse the first half later.

    @dakersnar
    dakersnar committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    b0721b8 View commit details
    Browse the repository at this point in the history

  2. Slight refactor to remove unneccesary calculation from the helper fun… 

    …ction
    @dakersnar
    dakersnar committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    d213837 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2022

  1. WIP: Decimal.DecCalc

    @dakersnar
    dakersnar committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    728efa1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/dotnet/runtime into fix-68042

    @dakersnar
    dakersnar committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    31820e3 View commit details
    Browse the repository at this point in the history

  3. WIP: Number.Dragon4.cs

    @dakersnar
    dakersnar committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    1df3d17 View commit details
    Browse the repository at this point in the history

  4. WIP: DecimalTests.cs

    @dakersnar
    dakersnar committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    246483c View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2022

  1. Initial unit test now passing

    @dakersnar
    dakersnar committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    40fcdd5 View commit details
    Browse the repository at this point in the history

  2. Updated decimal unit test file

    @dakersnar
    dakersnar committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    7e6cd93 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2022

  1. WIP: Current state of this fix

    @dakersnar
    dakersnar committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    e77161f View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2022

  1. Remove unneeded include

    @dakersnar
    dakersnar committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    29bac4b View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2022

  1. Possible working solution

    @dakersnar
    dakersnar committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    94b874b View commit details
    Browse the repository at this point in the history

  2. Fix naming, fix typo of tests

    @dakersnar
    dakersnar committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    6525508 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2022

  1. Adjust comments, tweak style, canonicalize result

    @dakersnar
    dakersnar committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    895b413 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2022

  1. Update unit test data to be more accurate for double and float

    @dakersnar
    dakersnar committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    5d9edfa View commit details
    Browse the repository at this point in the history

  2. Fix edge cases

    @dakersnar
    dakersnar committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    e6dbd62 View commit details
    Browse the repository at this point in the history

  3. Fix precision of returned zeros

    @dakersnar
    dakersnar committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    2d191a1 View commit details
    Browse the repository at this point in the history

  4. Fix expected values in Decimal's Generic Math tests

    @dakersnar
    dakersnar committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    47ac650 View commit details
    Browse the repository at this point in the history

  5. Fix test data for InsertDecimal and AppendDecimal tests

    @dakersnar
    dakersnar committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    6db7625 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2022

  1. Fix rounding issues

    @dakersnar
    dakersnar committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    1d38279 View commit details
    Browse the repository at this point in the history

  2. Slight improvement for decimal->double conversion

    @dakersnar
    dakersnar committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    1c3556d View commit details
    Browse the repository at this point in the history

  3. Fix rounding

    @dakersnar
    dakersnar committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    ceccdb5 View commit details
    Browse the repository at this point in the history

  4. Normalize test data

    @dakersnar
    dakersnar committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    2030e68 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2022

  1. Revert "Slight improvement for decimal->double conversion" 

    This reverts commit 1c3556d.
    @dakersnar
    dakersnar committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    f1d0451 View commit details
    Browse the repository at this point in the history

  2. Remove accidental push to DecCalc

    @dakersnar
    dakersnar committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    8a28c84 View commit details
    Browse the repository at this point in the history

  3. Fix Number.BigInteger DivRem Bug

    @dakersnar
    dakersnar committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    6a7266c View commit details
    Browse the repository at this point in the history

  4. Remove round trip tests temporarily until decimal to double conversio… 

    …n is fixed
    @dakersnar
    dakersnar committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    a62767d View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2022

  1. Fix comment typos

    @dakersnar
    dakersnar committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    23b71de View commit details
    Browse the repository at this point in the history