Omit calls to CCCryptorFinal #70618
Merged
Omit calls to CCCryptorFinal #70618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our use of CommonCrypto permits us to omit calls CCCryptorFinal, which gives a minor performance improvement.
|
Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones Issue DetailsOur use of CommonCrypto permits us to omit calls CCCryptorFinal (see comments added in PR), which gives a minor performance improvement. The performance improvement will be about 5%-7% when operating on a single block of data to transform.
|
bartonjs
approved these changes
Jun 11, 2022
stephentoub
reviewed
Jun 12, 2022
...ibraries/System.Security.Cryptography/src/System/Security/Cryptography/AppleCCCryptorLite.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Jun 12, 2022
…/Cryptography/AppleCCCryptorLite.cs Co-authored-by: Stephen Toub <stoub@microsoft.com>
|
S.IO.FileSystem.Tests failures are #70626. Merging. |
ghost
locked as resolved and limited conversation to collaborators
bartonjs
added
the
needs-further-triage
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our use of CommonCrypto permits us to omit calls to CCCryptorFinal (see comments added in PR), which gives a minor performance improvement.
The performance improvement will be about 5%-7% when operating on a single block of data to transform.