-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm][debugger] Removed duplicated testcases as a follow-up for #70560 #71827
[wasm][debugger] Removed duplicated testcases as a follow-up for #70560 #71827
Conversation
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsTheories added in #70560 contained duplicated testcases with the existing ones. The previous PR aimed at correcting the logic + adding new tests. This one cleans up the duplicates and renames some entities to make the tests clearer.
|
src/mono/wasm/debugger/DebuggerTestSuite/EvaluateOnCallFrameTests.cs
Outdated
Show resolved
Hide resolved
src/mono/wasm/debugger/tests/debugger-test/debugger-evaluate-test.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the feedback, the changes look good.
Theories added in #70560 contained duplicated testcases with the existing ones. The previous PR aimed at correcting the logic + adding new tests. This one cleans up the duplicates and renames some entities to make the tests clearer.
Removals and reasons:
EvaluateAsyncMethods
is removed because inside there was a mess - inside we had astaticClass
that was in fact, an instance class and the method did not test anything async. It was replaced in the previous PR with:EvaluateNonStaticClassWithStaticFields
with 4 different methods out of which we check the OnEval reply: InstanceMethod (Run
), InstanceAsyncMethod (RunAsync
), StaticMethod (RunStatic
), StaticAsyncMethod (RunStaticAsync
)and
EvaluateStaticFieldsInStaticClass
with similar set of methods: StaticMethod (Run
) and StaticAsyncMethod (RunAsync
).EvaluateAsyncMethods
got removed, it means:test:
EvaluateStaticClassFromStaticMethod
(got replaced withEvaluateStaticFields
)test data:
yield return new object[]....
(got replaced withInlineData
forEvaluateStaticFields
).