Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/linker #72257

Merged
merged 5 commits into from
Jul 21, 2022
Merged

[main] Update dependencies from dotnet/linker #72257

merged 5 commits into from
Jul 21, 2022

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jul 15, 2022 •
edited

This pull request updates the following dependencies

From https://github.com/dotnet/linker

  • Subscription: 0d6d6ae4-f71f-4395-53e6-08d8e409d87d
  • Build: 20220719.1
  • Date Produced: July 19, 2022 6:11:54 PM UTC
  • Commit: 60f48c55b5e0183bd1cee4cfa14f1d9ad3d90935
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/linker build 20220…
64d81f6 
…714.1

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22362.3 -> To Version 7.0.100-1.22364.1
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Jul 15, 2022
@lewing
Copy link
Member

lewing commented Jul 15, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dotnet-maestro
Update dependencies from https://github.com/dotnet/linker build 20220…
f031f53 
…715.1

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22362.3 -> To Version 7.0.100-1.22365.1
@lewing
Copy link
Member

lewing commented Jul 16, 2022

cc @vitek-karas @agocke

@vitek-karas
Copy link
Member

@sbomer - this is due to correct analysis of lambdas. Could you please take a look, I think this needs a fix in the libraries code. And also probably removal of unnecessary annotations.

runtime/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/ReflectionEmitCachingMemberAccessor.cs

Line 30 in cc75427

static (key) => s_sourceAccessor.CreateConstructor(key.declaringType));

/cc @jkurdek

@sbomer
Copy link
Member

sbomer commented Jul 18, 2022

/azp run runtime-wasm, runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

This was referenced Jul 18, 2022
Closed
Closed
Closed
@dotnet-maestro
Update dependencies from https://github.com/dotnet/linker build 20220…
27105dc 
…718.1

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22362.3 -> To Version 7.0.100-1.22368.1
@runfoapp runfoapp bot mentioned this pull request Jul 19, 2022
Closed
@sbomer sbomer requested a review from vitek-karas July 19, 2022 18:03
@sbomer
Copy link
Member

sbomer commented Jul 19, 2022

Failures look like existing issues (see runfo issues linked to this one).

@dotnet-maestro
Update dependencies from https://github.com/dotnet/linker build 20220…
1e974c4 
…719.1

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22362.3 -> To Version 7.0.100-1.22369.1
@vitek-karas
Copy link
Member

The only failure is a timeout of LLVM job.

@vitek-karas vitek-karas merged commit 908f440 into main Jul 21, 2022
@dotnet-maestro dotnet-maestro bot deleted the darc-main-930f9564-857b-4b61-8536-e7d5af99db25 branch July 21, 2022 08:35
@ghost ghost locked as resolved and limited conversation to collaborators Aug 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@vitek-karas vitek-karas vitek-karas approved these changes

Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lewing @vitek-karas @sbomer @stephentoub