Move llvm-libunwind to src/native/external #72418
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
added
the
community-contribution
|
Also fixed cc @VSadov |
am11
changed the title
am11
force-pushed
the
feature/external/llvm-libunwind
branch
2 times, most recently
from
f91a797
to
f7e28d2
Compare
am11
force-pushed
the
feature/external/llvm-libunwind
branch
from
f7e28d2
to
6e94f64
Compare
| https://github.com/llvm/llvm-project/releases/tag/llvmorg-9.0.0 | ||
|
|
||
| Apply https://github.com/dotnet/runtime/commit/371905898f2c036cc30d662e8a6df162a21967a5 | ||
| Reapply changes from https://github.com/dotnet/runtime/commit/62075f115efeecaee9d94f87d0766d657a72fa76 |
There was a problem hiding this comment.
This file keeps track of how to reproduce src/native/external/llvm-libunwind/ directory from scratch. When we will upgrade to https://github.com/llvm/llvm-project/releases/tag/llvmorg-14.0.6 for example, we can update this file to reflect how are we diverging from upstream. It will also help us plan upstreaming the local patches.
There was a problem hiding this comment.
I think 62075f1 has the changes that the upstream also has.
I am ok with including that commit, if it makes the tracking more convenient, just wonder if that is expected.
There was a problem hiding this comment.
Those changes were added in v14.0.0-rc1:
our current version is 9.0.0. We can adjust the these additional deltas once we upgrade to newer version.
Contributes to #72344