-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set IsDynamicCodeCompiled as a managed constant to help #72762
Conversation
Tagging subscribers to this area: @dotnet/area-system-runtime-compilerservices Issue Detailswith trimming on platforms where it's always false
|
Is there a rule for when we use substitution and when ifdef ( |
For me substitutions are more suitable for logic that is optional |
Is the substitution for this still needed then? runtime/src/mono/System.Private.CoreLib/src/ILLink/ILLink.Substitutions.iOS.xml Lines 1 to 7 in 75476f9
runtime/src/mono/System.Private.CoreLib/src/ILLink/ILLink.Substitutions.wasm.xml Lines 9 to 11 in 75476f9
|
src/mono/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeFeature.Mono.cs
Outdated
Show resolved
Hide resolved
with trimming on platforms where it's always false
…vices/RuntimeFeature.Mono.cs Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
@marek-safar do you think we still needs this? |
Closing, as this PR is stale and conflicts with #80246. One comment I have here is that we run the ILLinker on CoreLib during dotnet/runtime's build. So the substitutions are made into the IL in the shipped assemblies already. I'm not sure there is an externally visible difference with this change. |
with trimming on platforms where it's always false