Get more libraries tests running with NativeAOT #72917
Conversation
* MetadataLoadContext tests need more work for single file testing in general. Filed a separate issue. * S.R.Intrinsics is now clean. Running it on NativeAOT found good JIT bugs (dotnet#72081, dotnet#72158). Promoting to a smoke test. * S.Drawing.Primitives was testing DataContractSerializer for whatever reason. Marked that as aggresive trimming incompatible. This wouldn't be covered by dotnet#72910. * Made S.R.InteropServices.ComDisabled fully pass by fixing exceptions we throw. * A couple tests won't ever make sense to run on NativeAOT so removed them from triage area.
ghost
assigned 
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@dotnet/ilc-contrib could someone have a look? The arm64 Release NativeAOT_Libs_Passing leg timed out again, but I checked the results for the newly enabled tests and they look good: https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-72917-merge-c1234bb06fe0466a94/System.Runtime.Intrinsics.Tests/1/console.3209b4ad.log?helixlogtype=result The ARM64 Windows Helix queues are getting severely backed up because we spend 50% of machine time doing nothing: dotnet/arcade#10168 |
| <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime.InteropServices.RuntimeInformation\tests\System.Runtime.InteropServices.RuntimeInformation.Tests.csproj" /> | ||
| <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime.Loader\tests\DefaultContext\System.Runtime.Loader.DefaultContext.Tests.csproj" /> | ||
| <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime.Loader\tests\RefEmitLoadContext\System.Runtime.Loader.RefEmitLoadContext.Tests.csproj" /> | ||
| <ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime.Serialization.Formatters\tests\System.Runtime.Serialization.Formatters.Tests.csproj" /> |
There was a problem hiding this comment.
System.Runtime.Serialization.Formatters is binary serialization that's not supported by design. This can be also moved to the non-interesting category.
There was a problem hiding this comment.
I want to at least have a quick look at the results first - many tests are already marked as conditional on IsBinaryFormatterSupported and this has tests for FormatterServices that have NativeAOT specifics.
Cc @dotnet/ilc-contrib