New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial riscv64 port #73385
Add initial riscv64 port #73385
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsThese are the initial configuration for
This is done with llvm 15 RC1 on the host, and llvm 14 in rootfs. Currently I am using this tag:
|
src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/RuntimeInformation.cs
Outdated
Show resolved
Hide resolved
The mono changes look ok otherwise. |
ce73a65
to
5ed29ec
Compare
@@ -87,24 +91,19 @@ endif(CLR_CMAKE_HOST_UNIX) | |||
|
|||
if(CLR_CMAKE_HOST_WIN32) | |||
if (CLR_CMAKE_TARGET_ARCH_AMD64) | |||
set(TARGET_AMD64 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were redundant; set in configurecompiler.cmake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
These are the initial configuration for
riscv64
support. With this delta, the build status of relevant subsets is as follow:-p:RuntimeFlavor=mono
, since singlefilehost is stuck due to pending clr support)-- Configuring done
point (introspection test, locating dependencies etc. are working). Now we just need to write code starting with PAL. :)This is done with llvm 15 RC1 on the host, and llvm 14 in rootfs. Currently I am using this tag:
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-20.04-cross-riscv64-20220803130642-5291f63
which has clang-9 in base (host) layer, so I installed llvm-15 manually and upstremed the change: dotnet/dotnet-buildtools-prereqs-docker#651.