Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address Sanitizer support in CoreCLR #74623

Merged
merged 59 commits into from
Jul 18, 2023
Merged

Address Sanitizer support in CoreCLR #74623

merged 59 commits into from
Jul 18, 2023

Commits on Mar 16, 2023

  1. Enable AddressSanitizer in CoreCLR, Libs, and Host and update runtime… 

    …-sanitized to run tests with ASAN on Linux and Mac
    @jkoritzinsky
    jkoritzinsky committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    e0c4a60 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2023

  1. Unify on HAS_ADDRESS_SANITIZER define name 

    Centralize setting up sanitizer flags.

Remove last usage of CLR_CMAKE_ENABLE_ASAN outside of eng/native

Remove unnecessary diffs

Use the cpuid intrinsic and enable ASAN on InitJitHelpers1.

Add comments for the places where we have ASAN disabled

Undo changes to src/coreclr/jit/CMakeLists.txt

Add docs and fix the docs in the build script.

Add docs for the SkipVCEnvInit hook
    @jkoritzinsky
    jkoritzinsky committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    6fc2555 View commit details
    Browse the repository at this point in the history

  2. Remove CRT runtime changes. We won't need this when we finally onboar… 

    …d to Windows with some changes they have coming down the pipeline, so remove them for now to reduce the diff of this PR.
    @jkoritzinsky
    jkoritzinsky committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    d7fe870 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2023

  1. Remove suppression now that we've fixed the underlying issue.

    @jkoritzinsky
    jkoritzinsky committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    007da09 View commit details
    Browse the repository at this point in the history

  2. Remove some Windows-only sanitizer CMake that we won't need when ASAN… 

    … is ready for us to consume on Windows.
    @jkoritzinsky
    jkoritzinsky committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    8d3615d View commit details
    Browse the repository at this point in the history

  3. Set schedule for runtime-sanitized pipeline

    @jkoritzinsky
    jkoritzinsky committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    92c4858 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. Remove workaround in JIT memory set/copy helpers now that the JIT bug… 

    … has been fixed.
    @jkoritzinsky
    jkoritzinsky committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    a1f9900 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. Add missing helix queues setup template.

    @jkoritzinsky
    jkoritzinsky committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    2978de4 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2023

  1. Fix missing command to build nativeaot runtime tests as nativeaot.

    @jkoritzinsky
    jkoritzinsky committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    203e70c View commit details
    Browse the repository at this point in the history

  2. Add a scenario name to trigger the extended timeout in the libraries … 

    …test helix configuration.
    @jkoritzinsky
    jkoritzinsky committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    eb9bf22 View commit details
    Browse the repository at this point in the history

  3. Remove extraneous whitespace.

    @jkoritzinsky
    jkoritzinsky committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    413410b View commit details
    Browse the repository at this point in the history

  4. Fix using the cross-targetting ILC when sanitizers are enabled. Also … 

    …pass through our TargetOS and TargetArchitecture variables to the publish command for our native sanitizers targets to correctly do their extra logic.
    @jkoritzinsky
    jkoritzinsky committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    da30efe View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' of github.com:dotnet/runtime into asan

    @jkoritzinsky
    jkoritzinsky committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    b99fab9 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2023

  1. Disable LSAN on the CustomMain test.

    @jkoritzinsky
    jkoritzinsky committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    cd167b3 View commit details
    Browse the repository at this point in the history

  2. Disable some tests on sanitized runtimes.

    @jkoritzinsky
    jkoritzinsky committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    8fcc66f View commit details
    Browse the repository at this point in the history

  3. Copy the sanitizer runtime for OSX NativeAOT runtime tests.

    @jkoritzinsky
    jkoritzinsky committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    931f444 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. Merge branch 'main' of github.com:dotnet/runtime into asan

    @jkoritzinsky
    jkoritzinsky committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    6732866 View commit details
    Browse the repository at this point in the history

  2. A little cleanup to try to get the build right now that we are always… 

    … doing cross-builds on Linux.
    @jkoritzinsky
    jkoritzinsky committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    3c7dd54 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. Fix crossgen-corelib.proj syntax.

    @jkoritzinsky
    jkoritzinsky committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    04d2d9f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:dotnet/runtime into asan

    @jkoritzinsky
    jkoritzinsky committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    97c848f View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. Fix cross-os dac builds to not include the host architecture in the o… 

    …utput path.
    @jkoritzinsky
    jkoritzinsky committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    9946108 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. Split the debugger components into a separate component and make the … 

    …"unsanitized cross components" build into an "unsanitized debugger components" build as it can't be part of the regular cross-components build
    @jkoritzinsky
    jkoritzinsky committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    982e701 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'asan' of /mnt/e/source/runtime into asan

    @jkoritzinsky
    jkoritzinsky committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    6239952 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. Always write out the host-arch path on Windows and update the cross-d… 

    …ac build script to expect that.
    @jkoritzinsky
    jkoritzinsky committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    6769613 View commit details
    Browse the repository at this point in the history

  2. Change to use the dynamic runtime on Windows, as ASAN in VS is moving… 

    … to a dynamic-only model.
    @jkoritzinsky
    jkoritzinsky committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    35d9bd7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'asan' of github.com:jkoritzinsky/runtime into asan

    @jkoritzinsky
    jkoritzinsky committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    8b19fd3 View commit details
    Browse the repository at this point in the history

  4. Update docker images to include the sanitizer runtimes in the crossro… 

    …otfs images.
    @jkoritzinsky
    jkoritzinsky committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    5ae90d3 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' of github.com:dotnet/runtime into asan

    @jkoritzinsky
    jkoritzinsky committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    647f73b View commit details
    Browse the repository at this point in the history

  6. Fix explicit image tags

    @jkoritzinsky
    jkoritzinsky committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    5873281 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2023

  1. The unsanitized build should be of the target architecture, not the h… 

    …ost architecture. As a result, we still need a cross-arch build for the cross-arch use cases when sanitized, as well as an unsanitized target arch build for the debugger tools.
    @jkoritzinsky
    jkoritzinsky committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    d996328 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2023

  1. Merge branch 'main' into asan

    @jkoritzinsky
    jkoritzinsky committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    2e452d4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'asan' of github.com:jkoritzinsky/runtime into asan

    @jkoritzinsky
    jkoritzinsky committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    2130d7b View commit details
    Browse the repository at this point in the history

  3. Turn off using the sigaltstack for NativeAOT tests that don't use the… 

    … asansupport.cpp default options
    @jkoritzinsky
    jkoritzinsky committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    dc26f51 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. Make sure the shared ASAN runtime is present for the nativeaot/SmokeT… 

    …ests/SharedLibrary test.
    @jkoritzinsky
    jkoritzinsky committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    6cc6ad8 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. Disable crossgen2 tests with sanitizers as they don't get us interest… 

    …ing coverage.
    @jkoritzinsky
    jkoritzinsky committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    591093e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:dotnet/runtime into asan

    @jkoritzinsky
    jkoritzinsky committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    d285048 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2023

  1. Fix custom default options and disable some more crossgen2-based tests.

    @jkoritzinsky
    jkoritzinsky committed May 1, 2023
    Configuration menu
    Copy the full SHA
    7187ff2 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. Simplify lookup of asan runtime on mac and fix copying the shared run… 

    …time for the SharedLibrary NativeAOT test.
    @jkoritzinsky
    jkoritzinsky committed May 3, 2023
    Configuration menu
    Copy the full SHA
    6448d19 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'asan' of github.com:jkoritzinsky/runtime into asan

    @jkoritzinsky
    jkoritzinsky committed May 3, 2023
    Configuration menu
    Copy the full SHA
    113f5b2 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. Disable test that's failing for weird reasons.

    @jkoritzinsky
    jkoritzinsky committed May 4, 2023
    Configuration menu
    Copy the full SHA
    11cccdf View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:dotnet/runtime into asan

    @jkoritzinsky
    jkoritzinsky committed May 4, 2023
    Configuration menu
    Copy the full SHA
    c0357af View commit details
    Browse the repository at this point in the history

  3. Fix one more alloc-dealloc mismatch that only started to show up afte… 

    …r test merging increased allocations in the runtime
    @jkoritzinsky
    jkoritzinsky committed May 4, 2023
    Configuration menu
    Copy the full SHA
    133e99b View commit details
    Browse the repository at this point in the history

Commits on May 5, 2023

  1. Disable the System.Text.Json test suite on sanitized builds as it cau… 

    …ses SO failures on Mac
    @jkoritzinsky
    jkoritzinsky committed May 5, 2023
    Configuration menu
    Copy the full SHA
    b863d6f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:dotnet/runtime into asan

    @jkoritzinsky
    jkoritzinsky committed May 5, 2023
    Configuration menu
    Copy the full SHA
    8a51e72 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2023

  1. Fix test exclusion

    @jkoritzinsky
    jkoritzinsky committed May 8, 2023
    Configuration menu
    Copy the full SHA
    98ed710 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. Merge branch 'main' of github.com:dotnet/runtime into asan

    @jkoritzinsky
    jkoritzinsky committed May 15, 2023
    Configuration menu
    Copy the full SHA
    4efdf96 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2023

  1. Merge branch 'main' of github.com:dotnet/runtime into asan

    @jkoritzinsky
    jkoritzinsky committed May 19, 2023
    Configuration menu
    Copy the full SHA
    6855c78 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Merge branch 'main' of github.com:dotnet/runtime into asan

    @jkoritzinsky
    jkoritzinsky committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    db5b069 View commit details
    Browse the repository at this point in the history

  2. PR feedback.

    @jkoritzinsky
    jkoritzinsky committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    6383866 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. Merge remote-tracking branch 'dotnet/main' into asan

    @jkoritzinsky
    jkoritzinsky committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    0f0fdf5 View commit details
    Browse the repository at this point in the history

  2. Fix mac build

    @jkoritzinsky
    jkoritzinsky committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    36a450e View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Merge branch 'main' into asan

    @jkoritzinsky
    jkoritzinsky committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    f6987ed View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Do review changes

    @jkoritzinsky
    jkoritzinsky committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    619966b View commit details
    Browse the repository at this point in the history

  2. Add libbootstrapper object files to the platform manifest now that Na… 

    …tiveAOT has
    @jkoritzinsky
    jkoritzinsky committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    929a042 View commit details
    Browse the repository at this point in the history

  3. Disable tests that check size on sanitized builds

    @jkoritzinsky
    jkoritzinsky committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    5913ca4 View commit details
    Browse the repository at this point in the history

  4. Use the built-in include_guard option

    @jkoritzinsky
    jkoritzinsky committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    b8b3762 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' of github.com:dotnet/runtime into asan

    @jkoritzinsky
    jkoritzinsky committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    c2433e5 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. Disable use-after-return checking in ASAN. CoreCLR doesn't do well wi… 

    …th parallel stacks.
    @jkoritzinsky
    jkoritzinsky committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    fa15f17 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Only pass the no UAR flag on C and CXX with Clang (not AppleClang).

    @jkoritzinsky
    jkoritzinsky committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    757a329 View commit details
    Browse the repository at this point in the history