Add a few missing char.IsXx helpers usage to RegexGenerator.Emitter.cs #75101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just pretties up the generated code if these ranges are used. With this, all of the char.IsXx helpers can be emitted.
|
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions Issue DetailsJust pretties up the generated code if these ranges are used. With this, all of the char.IsXx helpers can be emitted. These ranges are already covered by existing tests.
|
ghost
assigned 
danmoseley
approved these changes
Sep 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just pretties up the generated code if these ranges are used. With this, all of the char.IsXx helpers can be emitted.
These ranges are already covered by existing tests.