Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Add workaround for msbuild issue in tests #75743

Merged
merged 5 commits into from
Sep 17, 2022

Conversation

radical
Copy link
Member

@radical radical commented Sep 16, 2022

.. which causes it to crash. Issue - #74328 .

This can be removed once the sdk has a fix for this.

.. which causes it to crash. The issue is described in
dotnet/sdk#26965 besides other issues.

This can be removed once the sdk has a fix for this.
@radical radical added arch-wasm WebAssembly architecture area-Build-mono labels Sep 16, 2022
@radical radical requested a review from naricc September 16, 2022 04:56
@ghost ghost assigned radical Sep 16, 2022
@ghost
Copy link

ghost commented Sep 16, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

.. which causes it to crash. The issue is described in dotnet/sdk#26965 besides other issues.

This can be removed once the sdk has a fix for this.

Author: radical
Assignees: -
Labels:

arch-wasm, area-Build-mono

Milestone: -

@radical radical changed the title [wasm] Add workaround for msbuild issue [wasm] Add workaround for msbuild issue in tests Sep 16, 2022
@lewing
Copy link
Member

lewing commented Sep 16, 2022

#74328

@radical
Copy link
Member Author

radical commented Sep 16, 2022

/azp run runtime-wasm-perf

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@radekdoulik radekdoulik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radekdoulik
Copy link
Member

The failing test looks like #75606

@radical radical merged commit 2e18999 into dotnet:main Sep 17, 2022
@lewing
Copy link
Member

lewing commented Sep 23, 2022

/backport to release/7.0

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3114802206

@lewing
Copy link
Member

lewing commented Sep 23, 2022

@karelz @marcpopMSFT @carlossanlop this was merged in main 6 days ago, do we have any of the msbuild failures in main after that?

@lewing
Copy link
Member

lewing commented Sep 23, 2022

cc @rokonec

AR-May added a commit to AR-May/runtime that referenced this pull request Oct 3, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Oct 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants