Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: extend RBO partial inference to unsigned relops #75804

Merged
merged 3 commits into from Sep 19, 2022

Conversation

AndyAyersMS
Copy link
Member

@AndyAyersMS AndyAyersMS commented Sep 18, 2022

RBO can now partially infer from a pair of unsigned relops or an unsigned relop and an equality relop.

Fixes #65327.

Diffs

RBO can now partially infer from a pair of unsigned relops or an unsigned
relop and an equality relop.

Fixes dotnet#65327.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 18, 2022
@ghost ghost assigned AndyAyersMS Sep 18, 2022
@ghost
Copy link

ghost commented Sep 18, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

RBO can now partially infer from a pair of unsigned relops or an unsigned relop and an equality relop.

Fixes #65327.

Author: AndyAyersMS
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@AndyAyersMS
Copy link
Member Author

@EgorBo PTAL
cc @dotnet/jit-contrib

Not as many hits in SPMI as I might have liked. May need to scout a bit more and see if these are truly infrequent or else something else is getting in the way.

Copy link
Member

@EgorBo EgorBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it needs a compilation fix in the test since it fails to build

@AndyAyersMS AndyAyersMS merged commit 78528df into dotnet:main Sep 19, 2022
@dotnet dotnet locked as resolved and limited conversation to collaborators Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JIT doesn't eliminate redundant branch in guarded span.Slice
2 participants