Obsolete RSA.EncryptValue and RSA.DecryptValue

[deeprobin]

Fixes #73969.

namespace System.Security.Cryptography;

public partial class RSA : AsymmetricAlgorithm
{
+   [Obsolete("RSA.EncryptValue and DecryptValue are not supported and throw NotSupportedException. Use RSA.Encrypt and RSA.Decrypt instead.")]
    public virtual byte[] EncryptValue(byte[] rgb);
    
+   [Obsolete("RSA.EncryptValue and DecryptValue are not supported and throw NotSupportedException. Use RSA.Encrypt and RSA.Decrypt instead.")]
    public virtual byte[] DecryptValue(byte[] rgb);
}

public partial class RSACryptoServiceProvider : RSA
{
+   [Obsolete("RSA.EncryptValue and DecryptValue are not supported and throw NotSupportedException. Use RSA.Encrypt and RSA.Decrypt instead.")]
    public override byte[] EncryptValue(byte[] rgb);
    
+   [Obsolete("RSA.EncryptValue and DecryptValue are not supported and throw NotSupportedException. Use RSA.Encrypt and RSA.Decrypt instead.")]
    public override byte[] DecryptValue(byte[] rgb);
}

[dotnet-issue-labeler]

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

[ghost]

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fixes #73969.

namespace System.Security.Cryptography;

public partial class RSA : AsymmetricAlgorithm
{
+   [Obsolete("RSA.EncryptValue and DecryptValue are not supported and throw NotSupportedException. Use RSA.Encrypt and RSA.Decrypt instead.")]
    public virtual byte[] EncryptValue(byte[] rgb);
    
+   [Obsolete("RSA.EncryptValue and DecryptValue are not supported and throw NotSupportedException. Use RSA.Encrypt and RSA.Decrypt instead.")]
    public virtual byte[] DecryptValue(byte[] rgb);
}

public partial class RSACryptoServiceProvider : RSA
{
+   [Obsolete("RSA.EncryptValue and DecryptValue are not supported and throw NotSupportedException. Use RSA.Encrypt and RSA.Decrypt instead.")]
    public override byte[] EncryptValue(byte[] rgb);
    
+   [Obsolete("RSA.EncryptValue and DecryptValue are not supported and throw NotSupportedException. Use RSA.Encrypt and RSA.Decrypt instead.")]
    public override byte[] DecryptValue(byte[] rgb);
}

Author:	deeprobin
Assignees:	-
Labels:	area-System.Security, new-api-needs-documentation
Milestone:	-

[deeprobin]

Is there a guideline on obsoletions? Should they theoretically be a constant in Obsoletions.cs or does this not have to be to this small extent (4 public methods)?

[vcsjones]

This should be following the SYSLIB obsoletion pattern. See another PR like #67264 as an example.

1. Take the next SYSLIB obsolete diagnostic number from list-of-diagnostics.md (and update that table). As of writing, you would use SYSLIB0048.
2. Diagnostic message and ID are constants in src/libraries/Common/src/System/Obsoletions.cs
3. The ref file should be generated and it will resolve the constants.

For the tests, you would want to probably surround the obsolete method calls with

#pragma warning disable SYSLIB0048
rsa.EncryptValue(..);
#pragma warning restore SYSLIB0048

[vcsjones]

And make sure the DiagnosticId and UrlFormat is set in the [Obsolete] attribute.

[deeprobin]

@vcsjones Ready for re review :D

[vcsjones]

Looks good to me, but @bartonjs will need to give the approval.

[deeprobin]

@vcsjones Are you able to request a review from @bartonjs?

[bartonjs]

@vcsjones Are you able to request a review from @bartonjs?

It was on my TODO list 😄. But, now it's on my TO-DONE! list. Thanks, @deeprobin.

[ghost]

Added needs-breaking-change-doc-created label because this PR has the breaking-change label.

When you commit this breaking change:

1. Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the breaking change documentation template, then remove this needs-breaking-change-doc-created label.
2. Ask a committer to mail the .NET Breaking Change Notification DL.

Tagging @dotnet/compat for awareness of the breaking change.

[vcsjones]

Breaking change issue here: dotnet/docs#31614