[NativeAot] Start running S.R.Metadata tests #76583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was hitting a compiler crash due to System.Reflection.Metadata bug around generic attributes. Since we now host the compiler with RC1 bits, the problem should be gone. No merge for now because this should not be promoted to a smoke test, just unblocked in the extra-platforms run.
MichalStrehovsky
added
NO-MERGE
ghost
assigned
MichalStrehovsky
changed the title
MichalStrehovsky
removed
the
NO-MERGE
MichalStrehovsky
changed the title
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkotas
approved these changes
Oct 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was hitting a compiler crash due to System.Reflection.Metadata bug around generic attributes. Since we now host the compiler with .NET 7 RC1 bits, the problem is gone.
Cc @dotnet/ilc-contrib