Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loading app-local ICU #77065

Merged
merged 7 commits into from
Oct 17, 2022
Merged

Fix loading app-local ICU #77065

merged 7 commits into from
Oct 17, 2022

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Oct 14, 2022

#77045

Awhile ago we had a change #68847 to fix the build breaks because of obsoleted ICU APIs. The fix was changing static binding to the API during the compile time to be a runtime binding. This change work fine except we missed to do some pointer initialization when having app-local ICU .

@ghost ghost assigned tarekgh Oct 14, 2022
@ghost
Copy link

ghost commented Oct 14, 2022

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

#77045

Awhile ago we had a change #68847 to fix the build breaks because of obsoleted ICU APIs. The fix was changing static binding to the API during the compile time to be a runtime binding. This change work fine except we missed to do some pointer initialization when having app-local ICU .

Author: tarekgh
Assignees: -
Labels:

area-System.Globalization
Milestone: -

janvorli
janvorli approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@tarekgh
Copy link
Member Author

tarekgh commented Oct 14, 2022

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@tarekgh
Copy link
Member Author

tarekgh commented Oct 14, 2022

/azp run runtime, dotnet-linker-tests, runtime-dev-innerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Oct 16, 2022
Closed
jkotas
jkotas approved these changes Oct 16, 2022
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tarekgh
Copy link
Member Author

tarekgh commented Oct 17, 2022

The runtime (Build Build windows x64 checked NativeAOT) failure is unrelated and reported in the build analysis.

@tarekgh tarekgh merged commit a54293e into dotnet:main Oct 17, 2022
@tarekgh tarekgh deleted the FixLoadingAppLocalIcu branch October 17, 2022 14:42
@tarekgh
Copy link
Member Author

tarekgh commented Oct 17, 2022

/backport to release/6.0

@github-actions
Copy link
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/3266237250

@tarekgh
Copy link
Member Author

tarekgh commented Oct 17, 2022

/backport to release/7.0

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3266244962

This was referenced Oct 17, 2022
Merged
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

@janvorli janvorli janvorli approved these changes

Assignees

@tarekgh tarekgh

Labels
area-System.Globalization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tarekgh @jkotas @janvorli