Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JIT] X64 - More replacement sequences for integer multiplication by a constant #77137
[JIT] X64 - More replacement sequences for integer multiplication by a constant #77137
Changes from 49 commits
78c3247
06a60e1
7fb0095
86edb6c
0955d11
865cf95
999eac0
6ebf58e
6e8f28c
94968a4
64b523a
1cde9c0
c6fba6e
ff2b9a1
338dbe5
106c6b7
8fc5b37
e5835db
3be48bf
b3d4a5f
843617a
74b1071
90b7e7d
ead83a5
b5193c0
214625f
f7181d2
99c11b4
9ff6393
75313fb
c101d1b
647cddb
79bc2d5
47c818d
55b6212
1a736ff
c042862
bba5ba0
164f233
88311d6
160c68e
4c9f7d3
a80dd11
d8b4228
e7b140d
384ff0b
a935699
21335a6
05ac3f7
85ca0f4
e633fef
5a459d8
f40aa1c
19d26d1
923d10b
5ac902d
c8fb73b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind sharing the before and after dumps and a way to repro this? I can take a look why the 2 temps are not related to each other even though they are referring to the same local var.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What we talked about yesterday was about using
GT_LEA
where the index and base are the sameGT_LCL_VAR
. I've decided that constructing a newGT_LEA
op isn't worth doing in lowering; that optimization is now purely done in codegen - so I don't think we have to worry about it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fair to remove this comment as it not accurate enough, and I'll remove this description from the PR itself too.