Allow DecompressionHandler to be trimmed when the application isn't using AutomaticDecompression in HttpClient. #78198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing AutomaticDecompression in HttpClient. This allow for the Brotli compression code to be trimmed in a NativeAOT app that uses HttpClient, which is about 1 MB of size savings on Linux.
eerhardt
added
the
size-reduction
ghost
assigned 
|
Tagging subscribers to 'size-reduction': @eerhardt, @SamMonoRT, @marek-safar Issue DetailsThis allow for the Brotli and Deflate compression code to be trimmed in a NativeAOT app that uses HttpClient, which is about 1 MB of size savings on Linux. The idea is to make a Delegate that will create the DecompressionHandler object. If no one calls the setter for
|
stephentoub
approved these changes
Nov 11, 2022
stephentoub
reviewed
Nov 11, 2022
| // AutomaticDecompression is not being used. | ||
| private void EnsureDecompressionHandlerFactory() | ||
| { | ||
| _decompressionHandlerFactory ??= (settings, handler) => new DecompressionHandler(settings._automaticDecompression, handler); |
There was a problem hiding this comment.
Nit: just to make sure we don't accidentally create a closure
Suggested change
| _decompressionHandlerFactory ??= (settings, handler) => new DecompressionHandler(settings._automaticDecompression, handler); | |
| _decompressionHandlerFactory ??= static (settings, handler) => new DecompressionHandler(settings._automaticDecompression, handler); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allow for the Brotli and Deflate compression code to be trimmed in a NativeAOT app that uses HttpClient, which is about 1 MB of size savings on Linux.
The idea is to make a Delegate that will create the DecompressionHandler object. If no one calls the setter for
SocketsHttpHandler.AutomaticDecompression, then the Delegate staysnulland theDecompressionHandlerclass and its dependencies can be trimmed.