[wasm] Wasm.Build.Tests - build projects for net8.0 by default #79254
Conversation
|
Tagging subscribers to 'arch-wasm': @lewing Issue Detailsnull
|
…l the workload combinations
...oad.Mono.Toolchain.net7.Manifest/Microsoft.NET.Workload.Mono.Toolchain.net7.Manifest.pkgproj
Show resolved
Hide resolved
src/mono/wasm/templates/templates/browser/.template.config/template.json
Show resolved
Hide resolved
| @@ -19,29 +19,31 @@ internal sealed class PackageInstaller | |||
| private string _nugetConfigContents; | |||
| private TaskLoggingHelper _logger; | |||
| private string _packagesDir; | |||
| private bool _cleanPackagesdir; | |||
There was a problem hiding this comment.
should this be true by default ?
There was a problem hiding this comment.
This is now set _cleanPackagesdir = packagesPath is null; in the constructor. So, if packagesPath is set, IOW, we are using a shared packages path then we don't want it to be cleaned.
Also, the main task now creates all the temp files under a top level temporary directory which gets removed at the end. And that would include these paths too.
There was a problem hiding this comment.
Very cool. Would it make sense to not delete the directory when running on local machine && something failed ?
There was a problem hiding this comment.
I guess SKIP_PROJECT_CLEANUP=1 still works ?
There was a problem hiding this comment.
Good idea. I was disabling it in code when needed! I can add a similar env var for this. SKIP_PROJECT_CLEANUP is for WBT.
There was a problem hiding this comment.
I'll include this in a follow up PR.
|
The llvmfullaot failures are #79255 . |
ghost
locked as resolved and limited conversation to collaborators
|
this caused the perf pipeline to switch back to testing against net7 runtimes again and we haven't had perf data on net8 since then dotnet/perf-autofiling-issues#10700 |
Wasm.Build.Testsfortfm=net8.0by default