Use ArrayBuffer for write buffer management in HttpConnection #79525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsContributes to #61223 Similar idea as #79524 - makes the code easier to work with, allowing us to make future improvements such as pooling easier. This PR replaces the Sample in-memory numbers copying around 1000-byte requests and 1000-byte responses:
|
MihaZupan
force-pushed
the
http1connection-writebuffer
branch
from
0460673
to
8031ee4
Compare
Closed
MihaZupan
force-pushed
the
http1connection-writebuffer
branch
from
8031ee4
to
a81062a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #61223
Similar idea as #79524 - makes the code easier to work with, allowing us to make future improvements such as pooling easier.
This PR replaces the
WriteHeadersAsynclogic to synchronously buffer the headers, as we do in HTTP/2 and HTTP/3. This also gives us a slight perf advantage.Sample in-memory numbers copying around 1000-byte requests and 1000-byte responses: