Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit mneg for mul+neg on Arm64 #79550

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Emit mneg for mul+neg on Arm64 #79550

merged 1 commit into from
Jan 13, 2023

Conversation

SwapnilGaikwad
Copy link
Contributor

Contribute towards #68028

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Dec 12, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 12, 2022
@ghost
Copy link

ghost commented Dec 12, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Contribute towards #68028

Author: SwapnilGaikwad
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@SwapnilGaikwad
Copy link
Contributor Author

Unfortunately, it didn't make the expected impact on code size.

Output from spmidiff:

Overall (-680 bytes)
Collection Base size (bytes) Diff size (bytes)
libraries.pmi.Linux.arm64.checked.mch 63,841,844 -28
benchmarks.run.Linux.arm64.checked.mch 29,197,468 -12
coreclr_tests.run.Linux.arm64.checked.mch 550,350,008 -612
libraries.crossgen2.Linux.arm64.checked.mch 45,202,820 -28

@build-analysis build-analysis bot mentioned this pull request Dec 12, 2022
Closed
@a74nh
Copy link
Contributor

a74nh commented Dec 13, 2022

Looks like the failure is a known issue.

Also: adding @kunalspathak

@a74nh a74nh mentioned this pull request Dec 19, 2022
Open
28 tasks
@JulieLeeMSFT
Copy link
Member

@kunalspathak, PTAL.

@kunalspathak
Copy link
Member

/azp run runtime-coreclr superpmi-diffs

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

kunalspathak
kunalspathak requested changes Jan 11, 2023
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for superpmi-diff fresh result and to add couple of more test cases.

@ghost ghost added needs-author-action An issue or pull request that requires more info or actions from the author. and removed needs-author-action An issue or pull request that requires more info or actions from the author. labels Jan 11, 2023
@kunalspathak kunalspathak merged commit 8a5b42f into dotnet:main Jan 13, 2023
@SwapnilGaikwad SwapnilGaikwad deleted the github-emit-mneg branch January 13, 2023 15:58
@JulieLeeMSFT JulieLeeMSFT mentioned this pull request Feb 8, 2023
Closed
3 tasks
@ghost ghost locked as resolved and limited conversation to collaborators Feb 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kunalspathak kunalspathak kunalspathak approved these changes

Assignees

@SwapnilGaikwad SwapnilGaikwad

@kunalspathak kunalspathak

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SwapnilGaikwad @a74nh @JulieLeeMSFT @kunalspathak