Fix diagnostics found with new analyzer - CA1858 #79896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsFix diagnostics found with the new analyzer CA1853
|
danmoseley
reviewed
Dec 22, 2022
...on.Metadata/src/System/Reflection/PortableExecutable/DebugDirectory/DebugDirectoryBuilder.cs
Outdated
Show resolved
Hide resolved
danmoseley
approved these changes
Dec 22, 2022
…/PortableExecutable/DebugDirectory/DebugDirectoryBuilder.cs Co-authored-by: Dan Moseley <danmose@microsoft.com>
Closed
Youssef1313
reviewed
Dec 22, 2022
...on.Metadata/src/System/Reflection/PortableExecutable/DebugDirectory/DebugDirectoryBuilder.cs
Outdated
Show resolved
Hide resolved
buyaa-n
commented
Dec 22, 2022
...on.Metadata/src/System/Reflection/PortableExecutable/DebugDirectory/DebugDirectoryBuilder.cs
Outdated
Show resolved
Hide resolved
…/PortableExecutable/DebugDirectory/DebugDirectoryBuilder.cs
tarekgh
approved these changes
Dec 22, 2022
|
The failure unrelated andreported |
buyaa-n
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix diagnostics found with the new analyzer CA1858
Use 'StartsWith' instead of comparing the result of 'IndexOf' to 0implemented by @Youssef1313