Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: Fall back to a canonical SIMD handle in gtGetStructHandleForSimdOrHW #80240

Merged
merged 5 commits into from Jan 9, 2023

Conversation

jakobbotsch
Copy link
Member

Fix #80239

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 5, 2023
@ghost ghost assigned jakobbotsch Jan 5, 2023
@ghost
Copy link

ghost commented Jan 5, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #80239

Author: jakobbotsch
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@tannergooding
Copy link
Member

@jakobbotsch looks like some path is passing in a non simdType and that's causing an unreached to be hit.

@jakobbotsch
Copy link
Member Author

We call gtGetStructHandleForSimdOrHW on

N002 (  2,  2)              [000001] ---XG------ >>>HWINTRINSIC struct int LoadPairScalarVector64 <l:$183, c:$182>
N001 (  1,  1)              [000000] -----------                         └──▌  LCL_VAR   long   V00 arg0         u:1 (last use) $80

from gtGetStructHandleIfPresent. I'll make gtGetStructHandleIfPresent return NO_CLASS_HANDLE for non-SIMD HW intrinsics.

@jakobbotsch jakobbotsch merged commit edbdce5 into dotnet:main Jan 9, 2023
@jakobbotsch jakobbotsch deleted the fix-80239 branch January 9, 2023 09:30
@dotnet dotnet locked as resolved and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JIT: Invalid isSimdAsHWIntrinsic param passed in lclmorph
2 participants