Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Substrings from PhoneAttribute #80389

Merged
merged 1 commit into from Jan 10, 2023
Merged

Remove Substrings from PhoneAttribute #80389

merged 1 commit into from Jan 10, 2023

Conversation

stephentoub
Copy link
Member

No description provided.

@ghost ghost assigned stephentoub Jan 9, 2023
@ghost
Copy link

ghost commented Jan 9, 2023

Tagging subscribers to this area: @ajcvickers, @bricelam, @roji
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: stephentoub
Assignees: stephentoub
Labels:

area-System.ComponentModel.DataAnnotations
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Jan 10, 2023
Open
eiriktsarpalis
eiriktsarpalis approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I take it that's the only attribute in this library that allocates substrings?

@stephentoub
Copy link
Member Author

I take it that's the only attribute in this library that allocates substrings?

The only one I found from a quick search at least. I could have missed one, of course.

@stephentoub stephentoub merged commit 36da90f into dotnet:main Jan 10, 2023
@stephentoub stephentoub deleted the phonesubstring branch January 10, 2023 12:48
@dotnet dotnet locked as resolved and limited conversation to collaborators Feb 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

Assignees

@stephentoub stephentoub

Labels
area-System.ComponentModel.DataAnnotations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stephentoub @eiriktsarpalis