New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable CA1859 - Use concrete types when possible for improved performance #80848
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
src/coreclr/nativeaot/System.Private.CoreLib/src/System/Array.NativeAot.cs
Outdated
Show resolved
Hide resolved
src/coreclr/tools/Common/Internal/NativeFormat/NativeFormatWriter.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.CSharp/src/Microsoft/CSharp/RuntimeBinder/ExpressionTreeCallRewriter.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Linq.Expressions/src/System/Linq/Expressions/BlockExpression.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.HttpListener/src/System/Net/WebSockets/HttpListenerWebSocketContext.cs
Outdated
Show resolved
Hide resolved
bc1736b
to
982c24d
Compare
7f07ef3
to
276f03b
Compare
@stephentoub could you review it? |
@@ -223,12 +223,12 @@ private static void CopySections(Stream outStream, Stream inputStream, Immutable | |||
} | |||
|
|||
#if NETCOREAPP2_1_OR_GREATER |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to your PR, but this is a strange choice of a compilation constant... Stream.ReadExactly was added in .NET 7, not .NET Core 2.1.
src/libraries/System.Net.Http/src/System/Net/Http/Headers/CacheControlHeaderValue.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Transactions.Local/src/System.Transactions.Local.csproj
Outdated
Show resolved
Hide resolved
2883548
to
a00d4a0
Compare
a00d4a0
to
8587541
Compare
Failures are unrelated. |
cc @stephentoub