Enable assert in perfScoreUnhandledInstruction #810

briansull · 2019-12-12T20:32:05Z

perfScoreUnhandledInstruction will now assert in a DEBUG or CHECKED build when it encounters an unhanded instruction

briansull · 2019-12-12T20:33:32Z

Related to PR #751

briansull · 2019-12-12T20:34:07Z

@tannergooding @BruceForstall @dotnet/jit-contrib PTAL

BruceForstall

Can you make sure to run outerloop and outerloop stress jobs? I wouldn't want this to cause new asserts to show up, especially as we aren't actively monitoring all the various pipelines yet.

briansull · 2019-12-12T22:41:00Z

I am leaving this PR open as I will be leaving for a vacation shortly.

briansull · 2020-01-17T00:32:29Z

@BruceForstall I have refreshed this

briansull · 2020-01-17T00:38:32Z

/AZP list

azure-pipelines · 2020-01-17T00:38:37Z

CI/CD Pipelines for this repository: coreclr-gc-longrunning coreclr-gc-simulator runtime-coreclr outerloop runtime-coreclr crossgen2 runtime-libraries outerloop runtime-libraries outerloop-windows runtime-libraries outerloop-linux runtime-libraries outerloop-osx runtime runtime-libraries enterprise-linux runtime-libraries stress-http runtime-libraries stress-ssl runtime-live-build runtime-coreclr crossgen2 outerloop coreclr-release-outerloop-nightly

briansull · 2020-01-17T00:49:21Z

/AZP runtime-coreclr outerloop

azure-pipelines · 2020-01-17T00:49:25Z

Command 'runtime-coreclr' is not supported by Azure Pipelines. Supported commands help: Get descriptions, examples and documentation about supported commands Example: help "command_name" list: List all pipelines for this repository using a comment. Example: "list" run: Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run. Example: "run" or "run pipeline_name, pipeline_name, pipeline_name" where: Report back the Azure DevOps orgs that are related to this repository and org Example: "where" See additional documentation.

briansull · 2020-01-17T00:50:23Z

/AZP run runtime-coreclr outerloop

azure-pipelines · 2020-01-17T00:50:29Z

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

briansull · 2020-01-17T18:48:08Z

There are some unhanded instructions for ARM64:

https://helix.dot.net/api/2019-06-17/jobs/25335df6-3701-444a-878f-9e5140003fcd/workitems/JIT.HardwareIntrinsics/console

Assert failure(PID 220 [0x000000dc], Thread: 220 [0x00dc]): Assertion failed '!"PerfScore: unhandled instruction"' in 'JIT.HardwareIntrinsics.Arm.SimpleBinaryOpTest__AbsoluteCompareGreaterThan_Vector128_Double:RunBasicScenario_UnsafeRead():this' (IL size 114)

tannergooding · 2020-01-17T18:55:49Z

CC. @EgorBo, @TamarChristinaArm, @CarolEidt

echesakov · 2020-01-17T19:59:32Z

@tannergooding I believe you wanted to ping me instead of Egor Bogatov. I added these instructions and I can update their perf score

tannergooding · 2020-01-17T20:42:23Z

Yes, sorry. Auto-complete chose the wrong person 😄

CarolEidt

My preference would be not to enable this assert. I'm not in favor of asserts that appear only when dumping or disassembling.

CarolEidt · 2020-01-17T21:34:12Z

src/coreclr/src/jit/emit.cpp

 //     and instead of returning we will assert
 //
-//     Otherwise we will return default latencies of 1 cycle.
+//     Remove the assert and we return default latencies of 1 cycle.


I think that this should be deleted, and the above comment should be clarified to say that it asserts in a DEBUG build, and returns a default latency of 1 cycle otherwise.

briansull · 2020-01-17T22:48:51Z

People working on Arm64 instructions could just add this change-set to their enlistment to catch the missing instructions. I put this PR up because Tanner wanted to have this enabled.

briansull · 2020-01-17T22:58:40Z

The outer loop testing printed these two missing instructions on Arm64:

PerfScore: unhandled instruction: facgt, format IF_DV_3B
PerfScore: unhandled instruction: crc32b, format IF_DR_3A

stephentoub · 2020-02-17T13:49:41Z

@briansull, what's the status of this PR? Should it be closed? Merged? Thanks.

briansull · 2020-02-18T20:44:01Z

@tannergooding do you still want this assert enabled by default?

tannergooding · 2020-02-18T20:55:07Z

It would be good to get it enabled as otherwise it just represents an increasing debt we are building for ARM64 (as we continue to add more instructions for the HWIntrinsic work, etc).

At this point, it should just require adding the instructions which aren't already covered, correct? Perhaps that is something that @echesakovMSFT, @CarolEidt, or myself can pick up and finish.

CarolEidt · 2020-02-18T21:28:03Z

I'm still of the opinion that we don't want asserts that fire only when dumping or disassembling. I would be OK with a COMPlus option that enables the assert.

tannergooding · 2020-02-18T21:33:23Z

I'm still of the opinion that we don't want asserts that fire only when dumping or disassembling. I would be OK with a COMPlus option that enables the assert.

IIRC, this fell out of #751 (comment) and only wasn't enabled due to parallel work from the HWIntrinsics.
This PR would just be enabling the same validation we already have for x64.

CarolEidt · 2020-02-18T22:32:58Z

My concern is with enabling an assert that only fires when I generate a dump or disassembly. This is not something we regularly do across all of our tests, and so it doesn't really add coverage. It is more likely to trip up someone who is working on something unrelated. These asserts should either be optionally enabled in dumps and disassembly (and included in some kind of stress testing) or the perfscore should always be computed for each instruction in checked builds, even when not disassembling.

briansull · 2020-02-18T23:49:02Z

The PerfScore is always computed for Checked and Debug builds, not only when you generate a dump or disassembly.

size_t emitter::emitIssue1Instr(insGroup* ig, instrDesc* id, BYTE** dp)
{
_..._

#if defined(DEBUG) || defined(LATE_DISASM)
    float insExeCost = insEvaluateExecutionCost(id);

CarolEidt · 2020-02-19T00:57:23Z

The PerfScore is always computed for Checked and Debug builds.

I see - I'd missed that - in that case, I'm OK with this. Sorry for the confusion.

…uild when it encounters an unhanded instruction

briansull · 2020-02-28T18:23:22Z

Rebased to a recent master:

@echesakovMSFT PTAL

set COMPlus_AltJitName=protononjit.dll
set COMPLUS_AltJitNgen=*
set COMPlus_TieredCompilation=0

crossgen.exe System.Private.CoreLib.dll
PerfScore: unhandled instruction: uminv, format IF_DV_2T
Assert failure(PID 53748 [0x0000d1f4], Thread: 55356 [0xd83c]): Assertion failed '!"PerfScore: unhandled instruction"' in 'System.Numerics.Plane:Equals(System.Numerics.Plane):bool:this' during 'Generate code' (IL size 132)

echesakov · 2020-02-28T19:20:14Z

@briansull I will add perf info later today - or if you want you can do this

briansull · 2020-02-28T19:53:15Z

@echesakovMSFT
I will look into adding them

…addlv, umaxv, uminv

briansull · 2020-02-28T20:56:19Z

Added PerfScore values for IF_DV_2T: // addv, saddlv, smaxv, sminv, uaddlv, umaxv, uminv

echesakov · 2020-02-28T21:34:49Z

Added PerfScore values for IF_DV_2T: // addv, saddlv, smaxv, sminv, uaddlv, umaxv, uminv

Thank you, @briansull !

…fcvtn, fcvtn2, fabd

briansull · 2020-02-28T23:26:18Z

Add PerfScore support for fcmeq, fcmge, fcmgt, fcmle, fcmlt, fcvtl2, fcvtn, fcvtn2, fabd

tannergooding · 2020-03-03T20:38:19Z

Thanks @briansull!

briansull mentioned this pull request Dec 12, 2019

Added PerfScore support for Arm64 #751

Merged

BruceForstall approved these changes Dec 12, 2019

View reviewed changes

sandreenko added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 18, 2019

tannergooding approved these changes Jan 6, 2020

View reviewed changes

briansull force-pushed the perfscore-assert branch from 613b11c to ccaf3b2 Compare January 17, 2020 00:07

CarolEidt reviewed Jan 17, 2020

View reviewed changes

echesakov mentioned this pull request Jan 31, 2020

[Arm64] Update execution characteristics for crc32b, crc32h, facge, facgt #8500

Merged

perfScoreUnhandledInstruction will now assert in a DEBUG or CHECKED b…

54c1e90

…uild when it encounters an unhanded instruction

briansull force-pushed the perfscore-assert branch from 263ad42 to 54c1e90 Compare February 28, 2020 00:56

Added PerfScore values for IF_DV_2T: // addv, saddlv, smaxv, sminv, u…

db05fa1

…addlv, umaxv, uminv

Add PerfScore support for fcmeq, fcmge, fcmgt, fcmle, fcmlt, fcvtl2, …

9266cfe

…fcvtn, fcvtn2, fabd

briansull added 3 commits March 2, 2020 10:52

Added PerfScore support for INS_addp

f52992e

Addded fmla and fmls

dcb1007

Update flma and fmls

6b0d3ee

jaredpar mentioned this pull request Mar 3, 2020

Getting HTTP 500 errors sending tests to Helix #33115

Closed

briansull merged commit c1e17e1 into dotnet:master Mar 3, 2020

ghost locked as resolved and limited conversation to collaborators Dec 11, 2020

Enable assert in perfScoreUnhandledInstruction #810

Enable assert in perfScoreUnhandledInstruction #810

Conversation

briansull commented Dec 12, 2019

briansull commented Dec 12, 2019

briansull commented Dec 12, 2019

BruceForstall left a comment

Choose a reason for hiding this comment

briansull commented Dec 12, 2019

briansull commented Jan 17, 2020

briansull commented Jan 17, 2020

azure-pipelines bot commented Jan 17, 2020

briansull commented Jan 17, 2020

azure-pipelines bot commented Jan 17, 2020

briansull commented Jan 17, 2020

azure-pipelines bot commented Jan 17, 2020

briansull commented Jan 17, 2020

tannergooding commented Jan 17, 2020

echesakov commented Jan 17, 2020 • edited Loading

tannergooding commented Jan 17, 2020

CarolEidt left a comment

Choose a reason for hiding this comment

CarolEidt Jan 17, 2020

Choose a reason for hiding this comment

briansull Jan 17, 2020

Choose a reason for hiding this comment

briansull commented Jan 17, 2020

briansull commented Jan 17, 2020

stephentoub commented Feb 17, 2020

briansull commented Feb 18, 2020

tannergooding commented Feb 18, 2020

CarolEidt commented Feb 18, 2020

tannergooding commented Feb 18, 2020

CarolEidt commented Feb 18, 2020

briansull commented Feb 18, 2020 • edited Loading

CarolEidt commented Feb 19, 2020

briansull commented Feb 28, 2020

echesakov commented Feb 28, 2020

briansull commented Feb 28, 2020

briansull commented Feb 28, 2020

echesakov commented Feb 28, 2020

briansull commented Feb 28, 2020

tannergooding commented Mar 3, 2020

echesakov commented Jan 17, 2020 •

edited

Loading

briansull commented Feb 18, 2020 •

edited

Loading